Merge pull request finos#1360 from dcoric/fix-1288

fix: remove unused fileDB params from config schema, defaults, and docs

Author: kriswest

config.schema.json

@@ -420,12 +420,7 @@
           "description": "Connection properties for an neDB file-based database",
           "properties": {
             "type": { "type": "string", "const": "fs" },
-            "enabled": { "type": "boolean" },
-            "params": {
-              "type": "object",
-              "description": "Legacy config property not currently used",
-              "deprecated": true
-            }
+            "enabled": { "type": "boolean" }
           },
           "required": ["type", "enabled"]
         }

packages/git-proxy-cli/test/testCli.proxy.config.json

@@ -13,9 +13,6 @@
   "sink": [
     {
       "type": "fs",
-      "params": {
-        "filepath": "./."
-      },
       "enabled": true
     },
     {

proxy.config.json

@@ -19,9 +19,6 @@
   "sink": [
     {
       "type": "fs",
-      "params": {
-        "filepath": "./."
-      },
       "enabled": true
     },
     {

src/config/generated/config.ts

@@ -496,10 +496,6 @@ export interface Database {
    */
   options?: Options;
   type: DatabaseType;
-  /**
-   * Legacy config property not currently used
-   */
-  params?: { [key: string]: any };
   [property: string]: any;
 }
 
@@ -938,7 +934,6 @@ const typeMap: any = {
       { json: 'enabled', js: 'enabled', typ: true },
       { json: 'options', js: 'options', typ: u(undefined, r('Options')) },
       { json: 'type', js: 'type', typ: r('DatabaseType') },
-      { json: 'params', js: 'params', typ: u(undefined, m('any')) },
     ],
     'any',
   ),

test-e2e.proxy.config.json

@@ -24,9 +24,6 @@
   "sink": [
     {
       "type": "fs",
-      "params": {
-        "filepath": "./."
-      },
       "enabled": false
     },
     {

test/generated-config.test.ts

@@ -96,9 +96,6 @@ describe('Generated Config (QuickType)', () => {
         sink: [
           {
             type: 'fs',
-            params: {
-              filepath: './.',
-            },
             enabled: true,
           },
         ],
@@ -149,7 +146,7 @@ describe('Generated Config (QuickType)', () => {
           { project: 'proj2', name: 'repo2', url: 'https://github.com/proj2/repo2.git' },
         ],
         authentication: [{ type: 'local', enabled: true }],
-        sink: [{ type: 'fs', params: { filepath: './.' }, enabled: true }],
+        sink: [{ type: 'fs', enabled: true }],
         plugins: ['plugin1', 'plugin2'],
         privateOrganizations: ['org1', 'org2'],
       };
@@ -167,7 +164,7 @@ describe('Generated Config (QuickType)', () => {
         proxyUrl: 'https://proxy.example.com',
         cookieSecret: 'secret',
         authentication: [{ type: 'local', enabled: true }],
-        sink: [{ type: 'fs', params: { filepath: './.' }, enabled: true }],
+        sink: [{ type: 'fs', enabled: true }],
         tls: {
           enabled: true,
           key: '/path/to/key.pem',
@@ -197,7 +194,7 @@ describe('Generated Config (QuickType)', () => {
         proxyUrl: 'https://proxy.example.com',
         cookieSecret: 'secret',
         authentication: [{ type: 'local', enabled: true }],
-        sink: [{ type: 'fs', params: { filepath: './.' }, enabled: true }],
+        sink: [{ type: 'fs', enabled: true }],
 
         api: {
           ls: {
@@ -236,7 +233,7 @@ describe('Generated Config (QuickType)', () => {
         proxyUrl: 'https://proxy.example.com',
         cookieSecret: 'secret',
         authentication: [{ type: 'local', enabled: true }],
-        sink: [{ type: 'fs', params: { filepath: './.' }, enabled: true }],
+        sink: [{ type: 'fs', enabled: true }],
 
         // Test different array structures
         authorisedList: [
@@ -267,7 +264,7 @@ describe('Generated Config (QuickType)', () => {
         proxyUrl: 'https://proxy.example.com',
         cookieSecret: 'secret',
         authentication: [{ type: 'local', enabled: true }],
-        sink: [{ type: 'fs', params: { filepath: './.' }, enabled: true }],
+        sink: [{ type: 'fs', enabled: true }],
 
         sessionMaxAgeHours: 0,
         csrfProtection: false,
@@ -313,7 +310,7 @@ describe('Generated Config (QuickType)', () => {
         proxyUrl: 'https://proxy.example.com',
         cookieSecret: null,
         authentication: [{ type: 'local', enabled: true }],
-        sink: [{ type: 'fs', params: { filepath: './.' }, enabled: true }],
+        sink: [{ type: 'fs', enabled: true }],
         contactEmail: null,
         urlShortener: null,
       };
@@ -328,7 +325,7 @@ describe('Generated Config (QuickType)', () => {
         proxyUrl: 'https://test.com',
         cookieSecret: 'secret',
         authentication: [{ type: 'local', enabled: true }],
-        sink: [{ type: 'fs', params: { filepath: './.' }, enabled: true }],
+        sink: [{ type: 'fs', enabled: true }],
         rateLimit: {
           windowMs: 60000,
           limit: 150,

website/docs/configuration/reference.mdx

@@ -1192,23 +1192,6 @@ Specific value: `"fs"`
 </blockquote>
 </details>
 
-<details>
-<summary>
-<strong> <a name="sink_items_oneOf_i1_params"></a>15.1.2.3. [Optional] Property GitProxy configuration file > sink > sink items > oneOf > item 1 > params</strong>
-</summary>
-<blockquote>
-
-|                           |                  |
-| ------------------------- | ---------------- |
-| **Type**                  | `object`         |
-| **Required**              | No               |
-| **Additional properties** | Any type allowed |
-
-**Description:** Legacy config property not currently used
-
-</blockquote>
-</details>
-
 </blockquote>
 
 </blockquote>
@@ -2046,4 +2029,4 @@ Specific value: `"jwt"`
 </details>
 
 ----------------------------------------------------------------------------------------------------------------------------
-Generated using [json-schema-for-humans](https://github.com/coveooss/json-schema-for-humans) on 2025-12-12 at 12:07:48 +0000
+Generated using [json-schema-for-humans](https://github.com/coveooss/json-schema-for-humans) on 2026-01-21 at 14:25:25 +0100