Skip to content

PR #2889

PR #2889 #566

Triggered via dynamic April 7, 2026 20:08
Status Success
Total duration 53s
Artifacts

codeql

on: dynamic
Matrix: analyze
Fit to window
Zoom out
Zoom in

Annotations

10 warnings
Analyze (actions)
Starting April 2026, the CodeQL Action will skip computing file coverage information on pull requests to improve analysis performance. File coverage information will still be computed on non-PR analyses. To opt out of this change, create a custom repository property with the name `github-codeql-file-coverage-on-prs` and the type "True/false", then set this property to `true` in the repository's settings.
Analyze (python)
Starting April 2026, the CodeQL Action will skip computing file coverage information on pull requests to improve analysis performance. File coverage information will still be computed on non-PR analyses. To opt out of this change, create a custom repository property with the name `github-codeql-file-coverage-on-prs` and the type "True/false", then set this property to `true` in the repository's settings.
using `clone` on type `Option<u64>` which implements the `Copy` trait: src/aggregation/metric/cardinality.rs#L203
warning: using `clone` on type `Option<u64>` which implements the `Copy` trait --> src/aggregation/metric/cardinality.rs:203:41 | 203 | missing_value_for_accessor: self.missing_value_for_accessor.clone(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.missing_value_for_accessor` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#clone_on_copy
using `clone` on type `ColumnType` which implements the `Copy` trait: src/aggregation/metric/cardinality.rs#L202
warning: using `clone` on type `ColumnType` which implements the `Copy` trait --> src/aggregation/metric/cardinality.rs:202:26 | 202 | column_type: self.column_type.clone(), | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.column_type` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#clone_on_copy
using `clone` on type `usize` which implements the `Copy` trait: src/aggregation/metric/cardinality.rs#L200
warning: using `clone` on type `usize` which implements the `Copy` trait --> src/aggregation/metric/cardinality.rs:200:27 | 200 | accessor_idx: self.accessor_idx.clone(), | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.accessor_idx` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#clone_on_copy = note: `#[warn(clippy::clone_on_copy)]` on by default
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: src/aggregation/metric/cardinality.rs#L150
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> src/aggregation/metric/cardinality.rs:150:43 | 150 | term_ords.into_iter().zip(coupons.into_iter()).collect(); | ^^^^^^^------------ | | | help: consider removing the `.into_iter()` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/e408947bfd200af42db322daf0fadfe7e26d3bd1/library/core/src/iter/traits/iterator.rs:620:11 = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default
this expression creates a reference which is immediately dereferenced by the compiler: src/aggregation/bucket/composite/mod.rs#L581
warning: this expression creates a reference which is immediately dereferenced by the compiler --> src/aggregation/bucket/composite/mod.rs:581:61 | 581 | let res = exec_request(agg_req.clone(), &index).unwrap(); | ^^^^^^ help: change this to: `index` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: src/aggregation/bucket/composite/mod.rs#L551
warning: this expression creates a reference which is immediately dereferenced by the compiler --> src/aggregation/bucket/composite/mod.rs:551:57 | 551 | let res = exec_request(agg_req.clone(), &index).unwrap(); | ^^^^^^ help: change this to: `index` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
function call inside of `expect`: src/aggregation/bucket/composite/mod.rs#L521
warning: function call inside of `expect` --> src/aggregation/bucket/composite/mod.rs:521:14 | 521 | .expect(&format!("Failed to parse date: {}", date_str)); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Failed to parse date: {}", date_str))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#expect_fun_call
function call inside of `expect`: src/aggregation/bucket/composite/mod.rs#L514
warning: function call inside of `expect` --> src/aggregation/bucket/composite/mod.rs:514:14 | 514 | .expect(&format!("Failed to parse date: {}", date_str)); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Failed to parse date: {}", date_str))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#expect_fun_call = note: `#[warn(clippy::expect_fun_call)]` on by default