PR #2889 #572
fulmicoton-ddcodeql
on: dynamic
Matrix: analyze
Annotations
7 warnings
|
Analyze (actions)
Starting April 2026, the CodeQL Action will skip computing file coverage information on pull requests to improve analysis performance. File coverage information will still be computed on non-PR analyses.
To opt out of this change, create a custom repository property with the name `github-codeql-file-coverage-on-prs` and the type "True/false", then set this property to `true` in the repository's settings.
|
|
Analyze (python)
Starting April 2026, the CodeQL Action will skip computing file coverage information on pull requests to improve analysis performance. File coverage information will still be computed on non-PR analyses.
To opt out of this change, create a custom repository property with the name `github-codeql-file-coverage-on-prs` and the type "True/false", then set this property to `true` in the repository's settings.
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
src/aggregation/metric/cardinality.rs#L168
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> src/aggregation/metric/cardinality.rs:168:43
|
168 | term_ords.into_iter().zip(coupons.into_iter()).collect();
| ^^^^^^^------------
| |
| help: consider removing the `.into_iter()`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/e408947bfd200af42db322daf0fadfe7e26d3bd1/library/core/src/iter/traits/iterator.rs:620:11
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/aggregation/bucket/composite/mod.rs#L581
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/aggregation/bucket/composite/mod.rs:581:61
|
581 | let res = exec_request(agg_req.clone(), &index).unwrap();
| ^^^^^^ help: change this to: `index`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/aggregation/bucket/composite/mod.rs#L551
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/aggregation/bucket/composite/mod.rs:551:57
|
551 | let res = exec_request(agg_req.clone(), &index).unwrap();
| ^^^^^^ help: change this to: `index`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
function call inside of `expect`:
src/aggregation/bucket/composite/mod.rs#L521
warning: function call inside of `expect`
--> src/aggregation/bucket/composite/mod.rs:521:14
|
521 | .expect(&format!("Failed to parse date: {}", date_str));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Failed to parse date: {}", date_str))`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#expect_fun_call
|
|
function call inside of `expect`:
src/aggregation/bucket/composite/mod.rs#L514
warning: function call inside of `expect`
--> src/aggregation/bucket/composite/mod.rs:514:14
|
514 | .expect(&format!("Failed to parse date: {}", date_str));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Failed to parse date: {}", date_str))`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#expect_fun_call
= note: `#[warn(clippy::expect_fun_call)]` on by default
|