Fix lints.

Author: MirahImage

.golangci.yml

@@ -8,7 +8,7 @@ linters:
     - dupl
     - errcheck
     - ginkgolinter
-    - goconst
+    # - goconst # disabled because it started triggering on field names
     - gocyclo
     - govet
     - ineffassign
@@ -37,6 +37,10 @@ linters:
           # - lll
           - dupl
         path: api/
+      - linters:
+          - staticcheck
+        path: api/
+        rule: SA1019
       - linters:
           - dupl
           # - lll

internal/controller/topology_controller.go

@@ -215,7 +215,7 @@ func (r *TopologyReconciler) getTopLevelField(obj topology.TopologyResource, pat
 		return nil
 	}
 	value := reflect.ValueOf(obj).Elem().FieldByName(path)
-	if value.Kind() == reflect.Ptr {
+	if value.Kind() == reflect.Pointer {
 		value = value.Elem()
 	}
 	if !value.IsValid() || !value.CanAddr() {

internal/controller/user_controller.go

@@ -23,7 +23,6 @@ import (
 	"k8s.io/apimachinery/pkg/runtime"
 	"k8s.io/apimachinery/pkg/types"
 	clientretry "k8s.io/client-go/util/retry"
-	"k8s.io/utils/ptr"
 	ctrl "sigs.k8s.io/controller-runtime"
 	"sigs.k8s.io/controller-runtime/pkg/client"
 	"sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
@@ -98,7 +97,7 @@ func (r *UserReconciler) declareCredentials(ctx context.Context, user *topology.
 			// https://github.com/rabbitmq/messaging-topology-operator/issues/194
 			for i := range credentialSecret.OwnerReferences {
 				if credentialSecret.ObjectMeta.OwnerReferences[i].Kind == user.Kind {
-					credentialSecret.ObjectMeta.OwnerReferences[i].BlockOwnerDeletion = ptr.To(false)
+					credentialSecret.ObjectMeta.OwnerReferences[i].BlockOwnerDeletion = new(false)
 				}
 			}
 			return nil

test/system/deletion_system_test.go

@@ -7,7 +7,6 @@ import (
 	topology "github.com/rabbitmq/messaging-topology-operator/api/v1beta1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/runtime"
-	"k8s.io/utils/ptr"
 
 	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
@@ -27,7 +26,7 @@ var _ = Describe("Deletion", func() {
 
 	BeforeEach(func() {
 		targetCluster = basicTestRabbitmqCluster("to-be-deleted", namespace)
-		targetCluster.Spec.TerminationGracePeriodSeconds = ptr.To(int64(10))
+		targetCluster.Spec.TerminationGracePeriodSeconds = new(int64(10))
 		setupTestRabbitmqCluster(k8sClient, targetCluster)
 		targetClusterRef := topology.RabbitmqClusterReference{Name: targetCluster.Name}
 		exchange = topology.Exchange{

test/system/utils_test.go

@@ -24,7 +24,6 @@ import (
 	"k8s.io/client-go/kubernetes"
 	"k8s.io/client-go/rest"
 	"k8s.io/client-go/tools/clientcmd"
-	"k8s.io/utils/ptr"
 )
 
 // Useful for small Openshift environment while updating status takes a long time
@@ -259,7 +258,7 @@ func basicTestRabbitmqCluster(name, namespace string) *rabbitmqv1beta1.RabbitmqC
 			Namespace: namespace,
 		},
 		Spec: rabbitmqv1beta1.RabbitmqClusterSpec{
-			Replicas: ptr.To(int32(1)),
+			Replicas: new(int32(1)),
 			Image:    "rabbitmq:4-management",
 			Resources: &corev1.ResourceRequirements{
 				Requests: corev1.ResourceList{