Skip to content

Commit aef6741

Browse files
committed
Fix unmatched return values in migrate_from_dets after clause
Both dets:close/1 and file:rename/2 return values that need to be explicitly ignored to satisfy the compiler's unmatched_returns check. Made-with: Cursor
1 parent 73700ef commit aef6741

2 files changed

Lines changed: 24 additions & 2 deletions

File tree

rebar3.crashdump

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
Error: terminated
2+
[{io,format,
3+
["===> Verifying dependencies...~n",[]],
4+
[{file,"io.erl"},
5+
{line,202},
6+
{error_info,#{cause => {io,terminated},module => erl_stdlib_errors}}]},
7+
{rebar_prv_install_deps,do,1,
8+
[{file,"/home/runner/work/rebar3/rebar3/apps/rebar/src/rebar_prv_install_deps.erl"},
9+
{line,73}]},
10+
{rebar_core,do,2,
11+
[{file,"/home/runner/work/rebar3/rebar3/apps/rebar/src/rebar_core.erl"},
12+
{line,155}]},
13+
{rebar3,run_aux,2,
14+
[{file,"/home/runner/work/rebar3/rebar3/apps/rebar/src/rebar3.erl"},
15+
{line,205}]},
16+
{rebar3,main,1,
17+
[{file,"/home/runner/work/rebar3/rebar3/apps/rebar/src/rebar3.erl"},
18+
{line,66}]},
19+
{init,start_it,1,[]},
20+
{init,start_em,1,[]},
21+
{init,do_boot,3,[]}]
22+

src/ra_log_meta.erl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -381,9 +381,9 @@ migrate_from_dets(MetaDets, ShuState0, _TblName) ->
381381

382382
{Count, ShuState2}
383383
after
384-
dets:close(DetsTable),
384+
_ = dets:close(DetsTable),
385385
%% Rename DETS file to .migrated
386-
file:rename(MetaDets, MetaDets ++ ".migrated")
386+
_ = file:rename(MetaDets, MetaDets ++ ".migrated")
387387
end.
388388

389389
%% Check if WAL usage exceeds watermark and start compaction if needed

0 commit comments

Comments
 (0)