Skip to content

Commit 2bd6a02

Browse files
Merge pull request #15616 from rabbitmq/mk-flake-fixes-mar-2-2026
STOMP `python_SUITE`: avoid resetting the node during setup
2 parents 0ce8cb5 + 728a341 commit 2bd6a02

2 files changed

Lines changed: 9 additions & 22 deletions

File tree

deps/rabbitmq_management/test/clustering_prop_SUITE.erl

Lines changed: 9 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -110,25 +110,26 @@ prop_connection_channel_counts(Config) ->
110110
begin
111111
% ensure we begin with no connections
112112
ct:pal("Init testcase"),
113-
true = validate_counts(Config, []),
113+
rabbit_ct_helpers:await_condition(
114+
fun () -> validate_counts(Config, []) end,
115+
60000),
114116
Cons = lists:foldl(fun (Op, Agg) ->
115117
execute_op(Config, Op, Agg)
116118
end, [], Ops),
117-
%% TODO retry a few times
118119
ct:pal("Check testcase"),
119-
Res = retry_for(
120-
fun() ->
121-
force_stats(Config),
122-
validate_counts(Config, Cons) end,
123-
60),
120+
rabbit_ct_helpers:await_condition(
121+
fun () ->
122+
force_stats(Config),
123+
validate_counts(Config, Cons) end,
124+
60000),
124125
ct:pal("Cleanup testcase"),
125126
rabbit_ct_helpers:await_condition(
126127
fun () ->
127128
cleanup(Cons),
128129
force_stats(Config),
129130
validate_counts(Config, []) end,
130131
60000),
131-
Res
132+
true
132133
end).
133134

134135
validate_counts(Config, Conns) ->
@@ -291,14 +292,3 @@ dump_table(Config, Table) ->
291292
ct:pal(?LOW_IMPORTANCE, "Node 0: Dump of table ~tp:~n~tp~n", [Table, Data]),
292293
Data0 = rabbit_ct_broker_helpers:rpc(Config, 1, ets, tab2list, [Table]),
293294
ct:pal(?LOW_IMPORTANCE, "Node 1: Dump of table ~tp:~n~tp~n", [Table, Data0]).
294-
295-
retry_for(_Fun, 0) ->
296-
false;
297-
retry_for(Fun, Retries) ->
298-
case Fun() of
299-
true ->
300-
true;
301-
false ->
302-
timer:sleep(1000),
303-
retry_for(Fun, Retries - 1)
304-
end.

deps/rabbitmq_stomp/test/python_SUITE_data/src/test_util.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,6 @@
1313

1414
def ensure_ssl_auth_user():
1515
user = 'O=client,CN=%s' % socket.gethostname()
16-
rabbitmqctl(['stop_app'])
17-
rabbitmqctl(['reset'])
18-
rabbitmqctl(['start_app'])
1916
rabbitmqctl(['add_user', user, 'foo'])
2017
rabbitmqctl(['clear_password', user])
2118
rabbitmqctl(['set_permissions', user, '.*', '.*', '.*'])

0 commit comments

Comments
 (0)