Providing a radix explicitly to parse_int is a good practice

michaelklishin · michaelklishin · commit 6441c0db42a8 · 2026-03-24T16:35:53.000-07:00
diff --git a/deps/rabbitmq_management/priv/www/js/prefs.js b/deps/rabbitmq_management/priv/www/js/prefs.js
@@ -239,7 +239,7 @@ function store_cookie(dict) {
     var date;
     if (sessionTimeout != undefined) {
         date = new Date();
-        date.setMinutes(date.getMinutes() + parseInt(sessionTimeout));
+        date.setMinutes(date.getMinutes() + parseInt(sessionTimeout, 10));
     } else {
         date = default_hard_session_timeout();
     }

Original file line number	Diff line number	Diff line change
`@@ -239,7 +239,7 @@ function store_cookie(dict) {`
`239`	`239`	`var date;`
`240`	`240`	`if (sessionTimeout != undefined) {`
`241`	`241`	`date = new Date();`
`242`		`- date.setMinutes(date.getMinutes() + parseInt(sessionTimeout));`
	`242`	`+ date.setMinutes(date.getMinutes() + parseInt(sessionTimeout, 10));`
`243`	`243`	`} else {`
`244`	`244`	`date = default_hard_session_timeout();`
`245`	`245`	`}`