Selenium tests: await refresh completion before asserting

michaelklishin · mergify[bot] · commit 91e60a9ed09d · 2026-03-25T17:12:53.000Z
(cherry picked from commit 7b9f956)
diff --git a/selenium/test/oauth/with-basic-auth/happy-login.js b/selenium/test/oauth/with-basic-auth/happy-login.js
@@ -50,7 +50,7 @@ describe('An user with administrator tag', function () {
     })
     it ('can reload page without being logged out', async function() {
       log("About to refresh page")
-      overview.refresh()      
+      await overview.refresh()
       if (!await overview.isLoaded()) {
         throw new Error('Failed to keep session opened')
       }
@@ -70,7 +70,7 @@ describe('An user with administrator tag', function () {
     })
     it ('can reload page without being logged out', async function() {
       log("About to refresh page")
-      overview.refresh()      
+      await overview.refresh()
       if (!await overview.isLoaded()) {
         throw new Error('Failed to keep session opened')
       }
diff --git a/selenium/test/oauth/with-idp-initiated-via-proxy/happy-login.js b/selenium/test/oauth/with-idp-initiated-via-proxy/happy-login.js
@@ -27,7 +27,7 @@ describe('A user with a JWT token', function () {
     await goToHome(driver);
     await overview.isLoaded();
 
-    overview.refresh()      
+    await overview.refresh()
     if (!await overview.isLoaded()) {
       throw new Error('Failed to keep session opened')
     }
diff --git a/selenium/test/oauth/with-idp-initiated/happy-login.js b/selenium/test/oauth/with-idp-initiated/happy-login.js
@@ -41,7 +41,7 @@ describe('A user with a JWT token', function () {
     await fakePortal.login()
     await overview.isLoaded()
 
-    overview.refresh()      
+    await overview.refresh()
     if (!await overview.isLoaded()) {
       throw new Error('Failed to keep session opened')
     }

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ describe('A user with a JWT token', function () {`
`27`	`27`	`await goToHome(driver);`
`28`	`28`	`await overview.isLoaded();`
`29`	`29`
`30`		`- overview.refresh()`
	`30`	`+ await overview.refresh()`
`31`	`31`	`if (!await overview.isLoaded()) {`
`32`	`32`	`throw new Error('Failed to keep session opened')`
`33`	`33`	`}`
Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ describe('A user with a JWT token', function () {`
`41`	`41`	`await fakePortal.login()`
`42`	`42`	`await overview.isLoaded()`
`43`	`43`
`44`		`- overview.refresh()`
	`44`	`+ await overview.refresh()`
`45`	`45`	`if (!await overview.isLoaded()) {`
`46`	`46`	`throw new Error('Failed to keep session opened')`
`47`	`47`	`}`