Refactor rabbit_channel from gen_server2 to gen_server#12209
Draft
mkuratczyk wants to merge 4 commits intomainfrom
Draft
Refactor rabbit_channel from gen_server2 to gen_server#12209mkuratczyk wants to merge 4 commits intomainfrom
mkuratczyk wants to merge 4 commits intomainfrom
Conversation
Collaborator
|
@mkuratczyk the AWS peer discovery failure almost certainly has nothing to do with these changes. Even after clearing certain resources the suite sometimes leaks, it (sometimes) continues failing on topic branches only to succeed in |
Collaborator
|
The AWS test suite is green after one more retry. |
lhoguin
requested changes
Sep 5, 2024
Contributor
lhoguin
left a comment
lhoguin
left a comment
There was a problem hiding this comment.
The changes are incomplete. The following callbacks specific to gen_server2 are still in the module but unused:
- handle_pre_hibernate/1
- handle_post_hibernate/1
- prioritise_call/4
- prioritise_cast/3
- prioritise_info/3
- format_message_queue/2
Priorities can likely just be removed. Format can likely be converted to format_status/1. Pre and post hibernate are a little more complex in that they do seemingly useful things so we need to make sure those things are still done, or remove them if they're not useful.
mkuratczyk
force-pushed
the
rabbit_channel-gs2-to-gen_server
branch
2 times, most recently
from
5cfbb9f to
f41fd14
Compare
`format_status` replaces the queue of pending messages, which is sometimes very long, with just the number of messages pending.
mkuratczyk
force-pushed
the
rabbit_channel-gs2-to-gen_server
branch
from
f41fd14 to
04144fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor rabbit_channel from gen_server2 to gen_server
Tests with 100B messages:
Tests with 1kB messages:
Tests with 5kB messages:
Tests with 20kB messages:
Full test results:
https://grafana.lionhead.rabbitmq.com/goto/cxGVTkeIR?orgId=1