Only add double-dash to args if there are previous app-host-added args (microsoft#7769)

* Only add double-dash to args if there are previous app-host-added args

* Update tests

* test to see if CI azure service bus somehow needs the double dash

* Revert "test to see if CI azure service bus somehow needs the double dash"

This reverts commit d128b27.

* move -- logic into BuildLaunchArgs

* remove nested if

---------

Co-authored-by: Adam Ratzman <adamratzman@microsoft.com>

Author: adamint

src/Aspire.Hosting/Dcp/DcpExecutor.cs

@@ -1024,6 +1024,12 @@ private async Task CreateExecutableAsync(AppResource er, ILogger resourceLogger,
                 var annotationOnly = spec.ExecutionType == ExecutionType.IDE;
 
                 var launchProfileArgs = GetLaunchProfileArgs(project.GetEffectiveLaunchProfile()?.LaunchProfile);
+                if (launchProfileArgs.Count > 0 && appHostArgs.Count > 0)
+                {
+                    // If there are app host args, add a double-dash to separate them from the launch args.
+                    launchProfileArgs.Insert(0, "--");
+                }
+
                 launchArgs.AddRange(launchProfileArgs.Select(a => (a, isSensitive: false, annotationOnly)));
             }
         }
@@ -1036,17 +1042,12 @@ private async Task CreateExecutableAsync(AppResource er, ILogger resourceLogger,
 
     private static List<string> GetLaunchProfileArgs(LaunchProfile? launchProfile)
     {
-        var args = new List<string>();
         if (launchProfile is not null && !string.IsNullOrWhiteSpace(launchProfile.CommandLineArgs))
         {
-            var cmdArgs = CommandLineArgsParser.Parse(launchProfile.CommandLineArgs);
-            if (cmdArgs.Count > 0)
-            {
-                args.Add("--");
-                args.AddRange(cmdArgs);
-            }
+            return CommandLineArgsParser.Parse(launchProfile.CommandLineArgs);
         }
-        return args;
+
+        return [];
     }
 
     private void PrepareContainers()

tests/Aspire.Hosting.Tests/Dcp/DcpExecutorTests.cs

@@ -106,9 +106,9 @@ public async Task ResourceStarted_ProjectHasReplicas_EventRaisedOnce()
     }
 
     [Theory]
-    [InlineData(ExecutionType.IDE, false, null, new string[] { "--", "--test1", "--test2" })]
+    [InlineData(ExecutionType.IDE, false, null, new string[] { "--test1", "--test2" })]
     [InlineData(ExecutionType.IDE, true, new string[] { "--withargs-test" }, new string[] { "--withargs-test" })]
-    [InlineData(ExecutionType.Process, false, new string[] { "--", "--test1", "--test2" }, new string[] { "--", "--test1", "--test2" })]
+    [InlineData(ExecutionType.Process, false, new string[] { "--test1", "--test2" }, new string[] { "--test1", "--test2" })]
     [InlineData(ExecutionType.Process, true, new string[] { "--", "--test1", "--test2", "--withargs-test" }, new string[] { "--", "--test1", "--test2", "--withargs-test" })]
     public async Task CreateExecutable_LaunchProfileHasCommandLineArgs_AnnotationsAdded(string executionType, bool addAppHostArgs, string[]? expectedArgs, string[]? expectedAnnotations)
     {