Make sure Queues are indexed by parameterized name

Instead of having them indexed by name and then having to go back and
forth between the two ways (original name and parameterized name) in the
URL. Also, ensure we use the parameterized name in the queues/index view
when linking to each queue.

Author: rosa

app/controllers/mission_control/jobs/queues_controller.rb

@@ -11,6 +11,6 @@ def show
 
   private
     def set_queue
-      @queue = ActiveJob.queues[params[:id]] || ActiveJob.queues.find { |q| q.id == params[:id] }
+      @queue = ActiveJob.queues[params[:id]]
     end
 end

app/views/mission_control/jobs/queues/_queue.html.erb

@@ -1,6 +1,6 @@
 <tr class="queue">
   <td>
-    <%= link_to queue.name, application_queue_path(@application, queue.name) %>
+    <%= link_to queue.name, application_queue_path(@application, queue) %>
     <% if queue.paused? %>
       <span class="ml-4 tag is-warning">Paused</span>
     <% end %>

lib/active_job/queues.rb

@@ -13,17 +13,21 @@ class ActiveJob::Queues
   include Enumerable
 
   delegate :each, to: :values
-  delegate :values, to: :queues_by_name, private: true
-  delegate :[], :size, :length, :to_s, :inspect, to: :queues_by_name
+  delegate :values, to: :queues_by_id, private: true
+  delegate :size, :length, :to_s, :inspect, to: :queues_by_id
 
   def initialize(queues)
-    @queues_by_name = queues.index_by(&:name).with_indifferent_access
+    @queues_by_id = queues.index_by(&:id).with_indifferent_access
   end
 
   def to_h
-    queues_by_name.dup
+    queues_by_id.dup
+  end
+
+  def [](name)
+    queues_by_id[name.to_s.parameterize]
   end
 
   private
-    attr_reader :queues_by_name
+    attr_reader :queues_by_id
 end

test/active_job/queue_test.rb

@@ -18,6 +18,16 @@ class ActiveJob::QueuesTest < ActiveSupport::TestCase
     assert_equal queue_2, queues["queue_2"]
   end
 
+  test "direct access by name with special characters parameterized" do
+    queue = ActiveJob::Queue.new("My-Queue_With.Special@Chars! and spaces")
+    queues = ActiveJob::Queues.new([ queue ])
+
+    # Look-up queue by original name
+    assert_equal queue, queues["My-Queue_With.Special@Chars! and spaces"]
+    # Look-up queue by parameterized, URL-friendly name
+    assert_equal queue, queues["my-queue_with-special-chars-and-spaces"]
+  end
+
   test "convert to hash" do
     queue_1 = create_queue "queue_1"
     queue_2 = create_queue "queue_2"