Simplify valid_recurring_config?

Author: J-Verz

lib/solid_queue/configuration.rb

@@ -70,34 +70,30 @@ def standalone?
     end
 
     def valid_recurring_config?
-      invalid = false
       invalid_tasks = Hash.new {|hash, key| hash[key] = [] }
       load_config_from(options[:recurring_schedule_file]).each do |env, tasks|
         tasks.each do |id, options|
           task = RecurringTask.from_configuration(id, **options)
-          if task.invalid?
-            invalid_tasks[env] << task
-            invalid = true
-          end
+          invalid_tasks[env] << task if task.invalid?
         end
       end
 
-      if invalid
-        puts "Invalid recurring tasks:"
-        invalid_tasks.each do |env, tasks|
-          puts "- #{env}"
-          tasks.each do |task|
-            puts "  - #{task.key}"
-            task.errors.full_messages.each do |message|
-              puts "    - #{message}"
-            end
+      if invalid_tasks.empty?
+        puts "All recurring tasks are valid"
+        return true
+      end
+
+      puts "Invalid recurring tasks:"
+      invalid_tasks.each do |env, tasks|
+        puts "- #{env}"
+        tasks.each do |task|
+          puts "  - #{task.key}"
+          task.errors.full_messages.each do |message|
+            puts "    - #{message}"
           end
         end
-        false
-      else
-        puts "All recurring tasks are valid"
-        true
       end
+      false
     end
 
     private