Remove Sections::List#sort_reverse because of having very limited use case

Closes #1181

Author: mshibuya

app/controllers/rails_admin/main_controller.rb

@@ -66,16 +66,14 @@ def back_or_index
 
     def get_sort_hash(model_config)
       abstract_model = model_config.abstract_model
-      params[:sort] = params[:sort_reverse] = nil unless model_config.list.fields.collect { |f| f.name.to_s }.include? params[:sort]
-      params[:sort] ||= model_config.list.sort_by.to_s
-      params[:sort_reverse] ||= 'false'
-
       field = model_config.list.fields.detect { |f| f.name.to_s == params[:sort] }
+
       column =
-        if field.nil? || field.sortable == true # use params[:sort] on the base table
-          "#{abstract_model.table_name}.#{params[:sort]}"
-        elsif field.sortable == false # use default sort, asked field is not sortable
+        if field.nil? || field.sortable == false # use default sort, asked field does not exist or is not sortable
+          field = model_config.list.possible_fields.detect { |f| f.name == model_config.list.sort_by.to_sym }
           "#{abstract_model.table_name}.#{model_config.list.sort_by}"
+        elsif field.sortable == true # use the given field
+          "#{abstract_model.table_name}.#{field.name}"
         elsif (field.sortable.is_a?(String) || field.sortable.is_a?(Symbol)) && field.sortable.to_s.include?('.') # just provide sortable, don't do anything smart
           field.sortable
         elsif field.sortable.is_a?(Hash) # just join sortable hash, don't do anything smart
@@ -86,8 +84,8 @@ def get_sort_hash(model_config)
           "#{abstract_model.table_name}.#{field.sortable}"
         end
 
-      reversed_sort = (field ? field.sort_reverse? : model_config.list.sort_reverse?)
-      {sort: column, sort_reverse: (params[:sort_reverse] == reversed_sort.to_s)}
+      params[:sort_reverse] ||= 'false'
+      {sort: column, sort_reverse: (params[:sort_reverse] == (field&.sort_reverse&.to_s || 'true'))}
     end
 
     def redirect_to_on_success

lib/rails_admin/config/has_fields.rb

@@ -116,6 +116,10 @@ def visible_fields
         all_fields.collect { |f| f.with(bindings) }.select(&:visible?).sort_by { |f| [f.order, i += 1] } # stable sort, damn
       end
 
+      def possible_fields
+        _fields(true)
+      end
+
     protected
 
       # Raw fields.

lib/rails_admin/config/sections/list.rb

@@ -32,10 +32,6 @@ class List < RailsAdmin::Config::Sections::Base
           parent.abstract_model.primary_key
         end
 
-        register_instance_option :sort_reverse? do
-          true # By default show latest first
-        end
-
         register_instance_option :scopes do
           []
         end
@@ -51,6 +47,10 @@ class List < RailsAdmin::Config::Sections::Base
         def fields_for_table
           visible_fields.partition(&:sticky?).flatten
         end
+
+        register_deprecated_instance_option :sort_reverse do
+          ActiveSupport::Deprecation.warn('The sort_reverse configuration option is deprecated and has no effect.')
+        end
       end
     end
   end

spec/integration/actions/index_spec.rb

@@ -795,20 +795,6 @@ def visit_page(page)
 
     before { @players = players.collect { |h| Player.create(h) } }
 
-    it 'is configurable per model' do
-      RailsAdmin.config Player do
-        list do
-          sort_by :created_at
-          sort_reverse true
-          field :name
-        end
-      end
-      visit index_path(model_name: 'player')
-      player_names_by_date.reverse.each_with_index do |name, i|
-        expect(find("tbody tr:nth-child(#{i + 1})")).to have_content(name)
-      end
-    end
-
     it 'has reverse direction by default' do
       RailsAdmin.config Player do
         list do
@@ -822,11 +808,13 @@ def visit_page(page)
       end
     end
 
-    it 'allows change default direction' do
+    it 'allows change direction by using field configuration' do
       RailsAdmin.config Player do
         list do
           sort_by :created_at
-          sort_reverse false
+          configure :created_at do
+            sort_reverse false
+          end
           field :name
         end
       end