Skip to content

Commit b385d4d

Browse files
committed
Fix filtering multi-select fails to deselect options
due to the behavior change in jQuery 3.0 https://jquery.com/upgrade-guide/3.0/#breaking-change-removeattr-no-longer-sets-properties-to-false Refs. #3389
1 parent aa5545c commit b385d4d

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

app/assets/javascripts/rails_admin/ra.filtering-multiselect.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@
225225
_deSelect: function(options) {
226226
var widget = this;
227227
options.each(function(i, option) {
228-
widget.element.find('option[value="' + option.value + '"]').removeAttr("selected");
228+
widget.element.find('option[value="' + option.value + '"]').prop('selected', false);
229229
});
230230
$(options).appendTo(this.collection).prop('selected', false);
231231
},

app/assets/javascripts/rails_admin/ra.nested-form-hooks.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@
5353
add_button.addClass('add_nested_fields').html(add_button.data('add-label'));
5454
}
5555
field.find('[required]').each(function() {
56-
$(this).removeAttr('required');
56+
$(this).prop('required', false);
5757
});
5858
});
5959
}(jQuery));

0 commit comments

Comments
 (0)