Skip to content

Commit b627580

Browse files
committed
Remove the legacy history adapter
Closes #3374
1 parent decf428 commit b627580

13 files changed

Lines changed: 4 additions & 199 deletions

File tree

.rubocop_todo.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,6 @@ Style/IfUnlessModifier:
245245
- 'lib/rails_admin/config/fields/types/multiple_active_storage.rb'
246246
- 'lib/rails_admin/config/inspectable.rb'
247247
- 'lib/rails_admin/extension.rb'
248-
- 'lib/rails_admin/extensions/history/history.rb'
249248
- 'lib/rails_admin/extensions/pundit/authorization_adapter.rb'
250249
- 'lib/rails_admin/support/csv_converter.rb'
251250

lib/rails_admin.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
require 'rails_admin/extensions/cancancan'
66
require 'rails_admin/extensions/pundit'
77
require 'rails_admin/extensions/paper_trail'
8-
require 'rails_admin/extensions/history'
98
require 'rails_admin/support/csv_converter'
109
require 'rails_admin/support/hash_helper'
1110
require 'yaml'

lib/rails_admin/config.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ def authenticate_with(&blk)
110110
@authenticate || DEFAULT_AUTHENTICATION
111111
end
112112

113-
# Setup auditing/history/versioning provider that observe objects lifecycle
113+
# Setup auditing/versioning provider that observe objects lifecycle
114114
def audit_with(*args, &block)
115115
extension = args.shift
116116
if extension

lib/rails_admin/extensions/history.rb

Lines changed: 0 additions & 3 deletions
This file was deleted.

lib/rails_admin/extensions/history/auditing_adapter.rb

Lines changed: 0 additions & 37 deletions
This file was deleted.

lib/rails_admin/extensions/history/history.rb

Lines changed: 0 additions & 44 deletions
This file was deleted.

spec/integration/actions/bulk_delete_spec.rb

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,6 @@
4949

5050
context 'on destroy' do
5151
before do
52-
RailsAdmin::History.destroy_all
53-
RailsAdmin.config { |c| c.audit_with :history }
5452
@players = Array.new(3) { FactoryBot.create(:player) }
5553
@delete_ids = @players[0..1].collect(&:id)
5654

@@ -63,15 +61,8 @@
6361
click_button "Yes, I'm sure"
6462
end
6563

66-
it 'does not contain deleted records', active_record: true do
67-
expect(RailsAdmin::AbstractModel.new('Player').count).to eq(1)
68-
expect(RailsAdmin::History.count).to eq(@delete_ids.count)
69-
RailsAdmin::History.all.each do |history|
70-
expect(history.table).to eq('Player')
71-
end
72-
RailsAdmin::History.all.each do |history|
73-
expect(@delete_ids).to include(history.item)
74-
end
64+
it 'does not contain deleted records' do
65+
expect(RailsAdmin::AbstractModel.new('Player').all.pluck(:id)).to eq([@players[2].id])
7566
expect(page).to have_selector('.alert-success', text: '2 Players successfully deleted')
7667
end
7768
end

spec/integration/history/rails_admin_paper_trail_spec.rb renamed to spec/integration/auditing/rails_admin_paper_trail_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
require 'spec_helper'
22
require 'paper_trail/frameworks/rspec' if defined?(PaperTrail)
33

4-
RSpec.describe 'RailsAdmin PaperTrail history', active_record: true do
4+
RSpec.describe 'RailsAdmin PaperTrail auditing', active_record: true do
55
before(:each) do
66
RailsAdmin.config do |config|
77
config.audit_with :paper_trail, 'User', 'PaperTrail::Version'

spec/integration/fields/has_many_association_spec.rb

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -43,25 +43,18 @@
4343

4444
context 'on update' do
4545
it 'is fillable and emptyable', active_record: true do
46-
RailsAdmin.config do |c|
47-
c.audit_with :history
48-
end
49-
5046
@league = FactoryBot.create :league
5147
@divisions = Array.new(3) { Division.create!(name: "div #{Time.now.to_f}", league: League.create!(name: "league #{Time.now.to_f}")) }
5248

5349
put edit_path(model_name: 'league', id: @league.id, league: {name: 'National League', division_ids: [@divisions[0].id]})
5450

55-
old_name = @league.name
5651
@league.reload
5752
expect(@league.name).to eq('National League')
5853
@divisions[0].reload
5954
expect(@league.divisions).to include(@divisions[0])
6055
expect(@league.divisions).not_to include(@divisions[1])
6156
expect(@league.divisions).not_to include(@divisions[2])
6257

63-
expect(RailsAdmin::History.where(item: @league.id).collect(&:message)).to include("name: \"#{old_name}\" -> \"National League\"")
64-
6558
put edit_path(model_name: 'league', id: @league.id, league: {division_ids: ['']})
6659

6760
@league.reload

spec/integration/history/rails_admin_history_spec.rb

Lines changed: 0 additions & 87 deletions
This file was deleted.

0 commit comments

Comments
 (0)