Show Gravater and email even if the current user is not editable

Closes #3237

Author: mshibuya

app/assets/stylesheets/rails_admin/base/theming.scss

@@ -26,6 +26,13 @@ body.rails_admin {
           margin-left: ($avatar-size + 5px);
         }
       }
+
+      > span {
+        color: $navbar-default-link-color;
+        line-height: $navbar-height;
+        padding-left: $navbar-padding-horizontal;
+        padding-right: $navbar-padding-horizontal;
+      }
     }
   }
 

app/helpers/rails_admin/application_helper.rb

@@ -22,12 +22,14 @@ def actions(scope = :all, abstract_model = nil, object = nil)
     def edit_user_link
       return nil unless _current_user.respond_to?(:email)
       return nil unless abstract_model = RailsAdmin.config(_current_user.class).abstract_model
-      return nil unless (edit_action = RailsAdmin::Config::Actions.find(:edit, controller: controller, abstract_model: abstract_model, object: _current_user)).try(:authorized?)
-      link_to rails_admin.url_for(action: edit_action.action_name, model_name: abstract_model.to_param, id: _current_user.id, controller: 'rails_admin/main') do
-        html = []
-        html << image_tag("#{(request.ssl? ? 'https://secure' : 'http://www')}.gravatar.com/avatar/#{Digest::MD5.hexdigest _current_user.email}?s=30", alt: '') if RailsAdmin::Config.show_gravatar && _current_user.email.present?
-        html << content_tag(:span, _current_user.email)
-        html.join.html_safe
+      content = [
+        RailsAdmin::Config.show_gravatar && _current_user.email.present? && image_tag("#{(request.ssl? ? 'https://secure' : 'http://www')}.gravatar.com/avatar/#{Digest::MD5.hexdigest _current_user.email}?s=30", alt: ''),
+        content_tag(:span, _current_user.email),
+      ].compact.join.html_safe
+      if (edit_action = RailsAdmin::Config::Actions.find(:edit, controller: controller, abstract_model: abstract_model, object: _current_user)).try(:authorized?)
+        link_to content, rails_admin.url_for(action: edit_action.action_name, model_name: abstract_model.to_param, id: _current_user.id, controller: 'rails_admin/main')
+      else
+        content_tag :span, content
       end
     end
 

spec/helpers/rails_admin/application_helper_spec.rb

@@ -470,6 +470,21 @@
         result = helper.edit_user_link
         expect(result).not_to include('gravatar')
       end
+
+      context 'when the user is not authorized to perform edit' do
+        let(:user) { FactoryBot.create(:user) }
+        before do
+          allow_any_instance_of(RailsAdmin::Config::Actions::Edit).to receive(:authorized?).and_return(false)
+          allow(helper).to receive(:_current_user).and_return(user)
+        end
+
+        it 'show gravatar and email without a link' do
+          result = helper.edit_user_link
+          expect(result).to include('gravatar')
+          expect(result).to include(user.email)
+          expect(result).not_to match('href')
+        end
+      end
     end
   end