Prevent autoloading on initialization for Zeitwerk compatibility

Fixes #3190

Author: mshibuya

app/controllers/rails_admin/application_controller.rb

@@ -11,6 +11,8 @@ class ActionNotAllowed < ::StandardError
   end
 
   class ApplicationController < Config.parent_controller.constantize
+    include RailsAdmin::Extensions::ControllerExtension
+
     protect_from_forgery(Config.forgery_protection_settings)
 
     before_action :_authenticate!

lib/rails_admin/extension.rb

@@ -1,3 +1,4 @@
+require 'rails_admin/extensions/controller_extension'
 
 module RailsAdmin
   EXTENSIONS = [] # rubocop:disable Style/MutableConstant
@@ -26,4 +27,15 @@ def self.add_extension(extension_key, extension_definition, options = {})
       AUDITING_ADAPTERS[extension_key] = extension_definition::AuditingAdapter
     end
   end
+
+  # Setup all extensions for testing
+  def self.setup_all_extensions
+    (AUTHORIZATION_ADAPTERS.values + AUDITING_ADAPTERS.values).each do |klass|
+      begin
+        klass.setup if klass.respond_to? :setup
+      rescue # rubocop:disable Lint/HandleExceptions
+        # ignore errors
+      end
+    end
+  end
 end

lib/rails_admin/extensions/controller_extension.rb

@@ -0,0 +1,6 @@
+module RailsAdmin
+  module Extensions
+    module ControllerExtension
+    end
+  end
+end

lib/rails_admin/extensions/paper_trail/auditing_adapter.rb

@@ -31,6 +31,12 @@ def item
         end
       end
 
+      module ControllerExtension
+        def user_for_paper_trail
+          _current_user.try(:id) || _current_user
+        end
+      end
+
       class AuditingAdapter
         COLUMN_MAPPING = {
           table: :item_type,
@@ -52,11 +58,7 @@ class AuditingAdapter
 
         def self.setup
           raise('PaperTrail not found') unless defined?(::PaperTrail)
-          RailsAdmin::ApplicationController.class_eval do
-            def user_for_paper_trail
-              _current_user.try(:id) || _current_user
-            end
-          end
+          RailsAdmin::Extensions::ControllerExtension.send(:include, ControllerExtension)
         end
 
         def initialize(controller, user_class = 'User', version_class = '::Version')

lib/rails_admin/extensions/pundit/authorization_adapter.rb

@@ -7,9 +7,7 @@ module Pundit
       class AuthorizationAdapter
         # This method is called first time only and used for setup
         def self.setup
-          RailsAdmin::ApplicationController.class_eval do
-            include ::Pundit
-          end unless RailsAdmin::ApplicationController.ancestors.include? 'Pundit'
+          RailsAdmin::Extensions::ControllerExtension.send(:include, ::Pundit)
         end
 
         # See the +authorize_with+ config method for where the initialization happens.

spec/integration/history/rails_admin_paper_trail_spec.rb

@@ -9,13 +9,6 @@
     end
   end
 
-  after(:each) do
-    # if #user_for_paper_trail is left unused, PaperTrail complains about it
-    RailsAdmin::ApplicationController.class_eval do
-      undef user_for_paper_trail
-    end
-  end
-
   shared_examples :paper_on_object_creation do
     describe 'on object creation', type: :request do
       subject { page }

spec/spec_helper.rb

@@ -56,6 +56,8 @@ def password_digest(password)
 Capybara.javascript_driver = :poltergeist
 Capybara.server = :webrick
 
+RailsAdmin.setup_all_extensions
+
 RSpec.configure do |config|
   config.expect_with :rspec do |c|
     c.syntax = :expect