Skip to content

Commit e5bb7ba

Browse files
authored
Fix orderable multiselect buttons (#3506)
* add .vscode to gitignore * Change Up/Down multiselect labels to titles Run prettier
1 parent 42d668f commit e5bb7ba

2 files changed

Lines changed: 5 additions & 9 deletions

File tree

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
*.swp
55
.bundle
66
.idea/
7+
.vscode/
78
.rvmrc
89
.sass-cache
910
.yardoc

src/rails_admin/filtering-multiselect.js

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import jQuery from "jquery";
22
import "jquery-ui/ui/widget";
33
import I18n from "./i18n";
4-
54
(function ($) {
65
$.widget("ra.filteringMultiselect", {
76
_cache: {},
@@ -112,15 +111,11 @@ import I18n from "./i18n";
112111
}
113112
if (this.options.sortable) {
114113
this.up = $(
115-
'<a href="#" class="fas fa-chevron-circle-up ra-multiselect-item-up">' +
116-
this.options.regional.up +
117-
"</a>"
118-
);
114+
'<a href="#" class="fas fa-chevron-circle-up ra-multiselect-item-up"></a>'
115+
).attr("title", this.options.regional.up);
119116
this.down = $(
120-
'<a href="#" class="fas fa-chevron-circle-down ra-multiselect-item-down">' +
121-
this.options.regional.down +
122-
"</a>"
123-
);
117+
'<a href="#" class="fas fa-chevron-circle-down ra-multiselect-item-down"></a>'
118+
).attr("title", this.options.regional.down);
124119
columns.center.append(this.up).append(this.down);
125120
}
126121

0 commit comments

Comments
 (0)