Skip to content

Commit e9a7ad6

Browse files
committed
Support sass-rails 6. Fixes #3129
1 parent 0e341a4 commit e9a7ad6

6 files changed

Lines changed: 14 additions & 14 deletions

File tree

Appraisals

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ end
9090

9191
appraise "rails-6.0" do
9292
gem 'rails', '~> 6.0.0.rc1'
93-
gem 'sass-rails', '~> 5.0'
93+
gem 'sass-rails', ['>= 6.0.0.beta3', '< 7']
9494
gem 'devise', '~> 4.4'
9595

9696
group :test do

gemfiles/rails_6.0.gemfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ gem "appraisal", ">= 2.0"
66
gem "rails", "~> 6.0.0.rc1"
77
gem "haml"
88
gem "devise", "~> 4.4"
9-
gem "sass-rails", "~> 5.0"
9+
gem "sass-rails", [">= 6.0.0.beta3", "< 7"]
1010

1111
group :active_record do
1212
gem "paper_trail", ">= 5.0"

lib/rails_admin/bootstrap-sass.rb

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,10 @@ def self.load!
1717
raise(Bootstrap::FrameworkNotFound.new('bootstrap-sass requires either Rails > 3.1 or Compass, neither of which are loaded'))
1818
end
1919

20-
stylesheets = File.expand_path(File.join('..', 'vendor', 'assets', 'stylesheets'))
21-
::Sass.load_paths << stylesheets
20+
if defined?(::Sass) && ::Sass.respond_to?(:load_paths)
21+
stylesheets = File.expand_path(File.join('..', 'vendor', 'assets', 'stylesheets'))
22+
::Sass.load_paths << stylesheets
23+
end
2224
end
2325

2426
def self.asset_pipeline?

lib/rails_admin/bootstrap-sass/sass_functions.rb

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
require 'sass'
2-
31
module Sass
42
module Script
53
module Functions
@@ -12,7 +10,7 @@ def ie_hex_str(color)
1210
alphastr = alpha.to_s(16).rjust(2, '0')
1311
Sass::Script::String.new("##{alphastr}#{color.send(:hex_str)[1..-1]}".upcase)
1412
end
15-
declare :ie_hex_str, [:color]
13+
declare :ie_hex_str, [:color] if respond_to?(:declare)
1614
end
1715
end
1816
end

rails_admin.gemspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ Gem::Specification.new do |spec|
1616
spec.add_dependency 'rack-pjax', '>= 0.7'
1717
spec.add_dependency 'rails', ['>= 5.0', '< 7']
1818
spec.add_dependency 'remotipart', '~> 1.3'
19-
spec.add_dependency 'sass-rails', ['>= 4.0', '< 6']
19+
spec.add_dependency 'sass-rails', ['>= 4.0', '< 7']
2020
spec.add_dependency 'activemodel-serializers-xml', '>= 1.0'
2121
spec.add_development_dependency 'bundler', '>= 1.0'
2222
spec.authors = ['Erik Michaels-Ober', 'Bogdan Gaza', 'Petteri Kaapa', 'Benoit Benezech', 'Mitsuhiro Shibuya']

spec/dummy_app/Gemfile

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
source 'https://rubygems.org'
22

3-
gem 'rails', '~> 5.0'
3+
gem 'rails', '>= 6.0.0.beta'
44
gem 'rack-cache', require: 'rack/cache'
55

66
group :active_record do
@@ -14,12 +14,12 @@ group :active_record do
1414
end
1515

1616
platforms :ruby, :mswin, :mingw do
17-
gem 'mysql2', '~> 0.3.14'
17+
gem 'mysql2', '>= 0.3.14'
1818
gem 'pg', '>= 0.14'
19-
gem 'sqlite3', '~> 1.3.0'
19+
gem 'sqlite3', '>= 1.3.0'
2020
end
2121

22-
gem 'paper_trail', '~> 5.0'
22+
gem 'paper_trail', '>= 5.0'
2323
end
2424

2525
group :mongoid do
@@ -37,15 +37,15 @@ gem 'mlb', '>= 0.7'
3737
gem 'paperclip', '>= 3.4'
3838
gem 'rails_admin', path: '../../'
3939

40-
platforms :ruby_21, :ruby_22 do
40+
platforms :mri do
4141
# gem 'refile', '>= 0.5', require: 'refile/rails'
4242
# gem 'refile-mini_magick', '>= 0.1.0'
4343
end
4444

4545
# Gems used only for assets and not required
4646
# in production environments by default.
4747
group :assets do
48-
gem 'sass-rails', '>= 4.0.3'
48+
gem 'sass-rails', '>= 6.0.0.beta'
4949
gem 'coffee-rails', '~> 4.0'
5050

5151
# See https://github.com/sstephenson/execjs#readme for more supported runtimes

0 commit comments

Comments
 (0)