refactor: add defensive type checks and improve null handling

Author: skiniks

crates/rari/src/rsc/rendering/core/js/component_eval_setup.js

@@ -1,5 +1,5 @@
 /* eslint-disable no-use-before-define, no-var, vars-on-top */
-if (!globalThis.React) {
+if (!globalThis.React || typeof globalThis.React.createElement !== 'function') {
   globalThis.React = {
     createElement(type, props, ...children) {
       const propsWithoutKey = props ? { ...props } : {}
@@ -29,7 +29,7 @@ if (typeof _jsxs === 'undefined')
 
 if (typeof globalThis.jsx === 'undefined') {
   globalThis.jsx = function (type, props, key) {
-    if (!globalThis.React)
+    if (!globalThis.React || typeof globalThis.React.createElement !== 'function')
       return null
 
     if (key !== undefined)
@@ -41,7 +41,7 @@ if (typeof globalThis.jsx === 'undefined') {
 
 if (typeof globalThis.jsxs === 'undefined') {
   globalThis.jsxs = function (type, props, key) {
-    if (!globalThis.React)
+    if (!globalThis.React || typeof globalThis.React.createElement !== 'function')
       return null
 
     if (key !== undefined)

crates/rari/src/server/middleware/request_context.rs

@@ -158,7 +158,7 @@ impl RequestContext {
 
         if let Some(result) = guard.as_ref() {
             let mut cloned_result = result.clone()?;
-            cloned_result.tags = Self::merge_and_sort_tags(cloned_result.tags, tags.clone());
+            cloned_result.tags = Self::merge_and_sort_tags(cloned_result.tags, tags);
 
             {
                 let mut cache = self.fetch_cache.lock();

packages/rari/src/router/navigation-error-handler.ts

@@ -134,7 +134,10 @@ export function createNavigationError(
     return handleTimeoutError(error, url)
 
   if (error instanceof Error && 'status' in error) {
-    const status = (error as any).status as number
+    const status = (error as any).status
+    if (typeof status !== 'number')
+      return handleUnknownError(error, url)
+
     return handleHttpError(error, status, url)
   }
 

packages/rari/src/runtime/shared/get-client-component.ts

@@ -64,7 +64,7 @@ async function ensureComponentLoaded(componentInfo: LazyComponentInfo, exportNam
 }
 
 function triggerComponentLoad(componentInfo: LazyComponentInfo): Promise<any> {
-  if (!componentInfo.loader || componentInfo.loading || componentInfo.component || componentInfo.loadPromise)
+  if (!componentInfo.loader || componentInfo.loading || componentInfo.component != null || componentInfo.loadPromise)
     return Promise.resolve(null)
 
   return executeLoader(componentInfo)