Skip to content

Commit 180560e

Browse files
committed
ipa: rpi: Fix missing controls
controls::rpi::SyncMode was missing in the ControlInfoMap and the direction of controls::rpi::ScalerCrops was incorrectly set to out. Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
1 parent 4fc8d2a commit 180560e

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

src/ipa/rpi/common/ipa_base.cpp

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,11 @@ const ControlInfoMap::Map ipaControls{
9393
{ &controls::draft::NoiseReductionMode, ControlInfo(controls::draft::NoiseReductionModeValues) },
9494
{ &controls::rpi::StatsOutputEnable, ControlInfo(false, true, false) },
9595
{ &controls::rpi::CnnEnableInputTensor, ControlInfo(false, true, false) },
96+
{ &controls::rpi::SyncMode,
97+
ControlInfo({ { ControlValue(controls::rpi::SyncModeOff),
98+
ControlValue(controls::rpi::SyncModeClient) } },
99+
ControlValue(controls::rpi::SyncModeOff)) },
100+
{ &controls::rpi::SyncFrames, ControlInfo(100, 100000, 1000) },
96101
};
97102

98103
/* IPA controls handled conditionally, if the sensor is not mono */

src/libcamera/control_ids_rpi.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ controls:
3535
- ScalerCrops:
3636
type: Rectangle
3737
size: [n]
38-
direction: out
38+
direction: inout
3939
description: |
4040
An array of rectangles, where each singular value has identical
4141
functionality to the ScalerCrop control. This control allows the

0 commit comments

Comments
 (0)