Don't reset to regular font on match None for bold and italic#125
Merged
j-g00da merged 1 commit intoratatui:mainfrom Sep 26, 2025
Merged
Don't reset to regular font on match None for bold and italic#125j-g00da merged 1 commit intoratatui:mainfrom
j-g00da merged 1 commit intoratatui:mainfrom
Conversation
Member
|
Nice catch, thanks! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already set font when first creating the style_builder, no need to reset it. This might also be wiping a previous setting. For example, if it has both italics and bold modifier, italics font is applied, but bold matches none, and resets font back to regular, we want to avoid such a behavior I assume.