perf(framebuffer): avoid cloning during flush for every frame#153
Merged
perf(framebuffer): avoid cloning during flush for every frame#153
Conversation
In my tests, I experienced this problem after each `Terminal::draw`
call:
```
PanicInfo { message: memory allocation of 1073608832 bytes failed }
```
That's a whopping 1.0 GiB of allocation. This happens because the
`&HeapBuffer` iterator cloned the entire framebuffer on each flush,
allocating `width × height × sizeof(C)` bytes per frame.
My guess is, on 32-bit embedded targets this can overflow and appear
as a massive allocation request.
The fix is to have the iterator borrow the existing buffer and yield
copied pixels instead, eliminating heap allocations on every frame.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my tests, I experienced this problem after each
Terminal::drawcall:
That's a whopping 1.0 GiB of allocation. This happens because the
&HeapBufferiterator cloned the entire framebuffer on each flush,allocating
width × height × sizeof(C)bytes per frame.My guess is, on 32-bit embedded targets this can overflow and appear
as a massive allocation request.
The fix is to have the iterator borrow the existing buffer and yield
copied pixels instead, eliminating heap allocations on every frame.