docs(esp32-no-std-demo): add note about SPI mode and display size#169
Merged
docs(esp32-no-std-demo): add note about SPI mode and display size#169
Conversation
Member
|
Should probably also describe the exact setup including circuit. You can wire up button and battery voltage reading exactly the same way as on original board with some custom hardware. |
Member
Author
|
How should we do that though? In the code or readme? Maybe add image somehow as well? |
Member
|
I think it would make sense to provide some readme in the example |
Member
Author
|
Created #170 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
regarding #165