docs(esp32 std demo): Add README.md for esp32-std-demo#171
docs(esp32 std demo): Add README.md for esp32-std-demo#171orhun merged 8 commits intoratatui:mainfrom
Conversation
The documentation for the ESP32 `std` demo has been added. Signed-off-by: Vaishnav Sabari Girish <vaishnav.sabari.girish@gmail.com>
There was a problem hiding this comment.
This includes much more than needed, while skipping what is actually important - e.g. how battery voltage reader is wired (it uses a voltage divider, it's described in the code*) so that someone can replicate the same circuit with different/custom board.
All three:
- driver
- screen offset
- screen size
are specific to the specific screen used in T-display and should be adjusted if using different one.
This PR looks AI generated...
EDIT: * I think I mixed it up with a different project; anyway the t-display pcb schematics are available online, it uses a voltage divider that halves the battery voltage before the ADC, that's why it's multiplied *2 in the code.
…to docs/document_setup
This commit adds the improvements as requested. Signed-off-by: Vaishnav Sabari Girish <vaishnav.sabari.girish@gmail.com>
3f13c0e to
86db9d5
Compare
orhun
left a comment
There was a problem hiding this comment.
I updated the style a bit. This should be alright to go.
86ae685 to
a902840
Compare
|
Can you revert the changes to 86ae685 ? With your last force-push the style changes are reverted. |
a902840 to
86ae685
Compare
|
I force pushed again |
Will look into it @orhun |
|
Nothing needs to be done here. Please don't overwrite the history again :) |
The documentation for the ESP32
stddemo has been added.