docs(readme): Add simulator screenshot#99
Conversation
|
I see we had a little race condition here. |
|
Also the picture path shouldn't be relative, or else this would cause a problem when we moved/renamed it in the future (images on crates.io and docs.rs would break) |
|
nit: conventional commits, please make such commits/pr titles that can finish the sentence So it should be "remove" and "add" instead of "removed" and "added". I know there's no information about it yet, I still have to finish the contribution guidelines. |
|
Hehe, didn't see that! I'll update just the picture.
Oh good catch, but how am I supposed to add a url to a file that does not exist yet? Also, how can this end up in crates.io/docs.rs if I'm only editing |
Thank you for the cheatsheet! I'm used to have my commits in the past tense. |
I often just do this in two commits, you can open a PR that just adds the image to assets and then use it here.
|
0312d75 to
7904516
Compare
|
All good now! |
7904516 to
dd1f6a0
Compare
Closing #96