Skip to content

Commit c866e3e

Browse files
authored
Merge pull request #1361 from rdmorganiser/2.3.2
RDMO 2.3.2 🐛🐛
2 parents d31198a + 4d17b95 commit c866e3e

108 files changed

Lines changed: 3500 additions & 956 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ jobs:
5555
# build the webpack bundle
5656
- uses: actions/setup-node@v4
5757
with:
58-
node-version: 18
58+
node-version: 22
5959
cache: npm
6060
- run: npm ci && npm run build:dist
6161
# build the wheel
@@ -246,7 +246,7 @@ jobs:
246246
run: python -m pip check
247247
- uses: actions/setup-node@v4
248248
with:
249-
node-version: 18
249+
node-version: 22
250250
cache: npm
251251
- run: npm install --include=dev
252252
- name: Write info to step summary

.nvmrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
18.20.1
1+
22.16

.pre-commit-config.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,12 @@ repos:
2222
exclude: \.dot$
2323
- id: debug-statements
2424
- repo: https://github.com/astral-sh/ruff-pre-commit
25-
rev: v0.11.8
25+
rev: v0.11.12
2626
hooks:
2727
- id: ruff
2828
args: [--fix, --exit-non-zero-on-fix]
2929
- repo: https://github.com/pre-commit/mirrors-eslint
30-
rev: v9.26.0
30+
rev: v9.28.0
3131
hooks:
3232
- id: eslint
3333
args: [--fix, --color]

CHANGELOG.md

Lines changed: 21 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,24 @@
1-
# Changelog
1+
# Changelog 📔
2+
3+
## [RDMO 2.3.2](https://github.com/rdmorganiser/rdmo/compare/2.3.1...2.3.2) (July 4, 2025)
4+
5+
* Improve ORCID branding display and social connections page (#1376)
6+
* Hide management panels by default (#1377)
7+
* Fix sets in the interview (#1367)
8+
* Fix copy value and apply only to empty sets (#1384)
9+
* Fix compute progress for non-empty values (#1374)
10+
* Fix bugs in sync of project tasks and views (#1362)
11+
* Added management command `./manage.py sync_projects`, with flags `--tasks`, `--views` or `--show`
12+
* Fix scroll focus (#1372)
13+
* Fix options in project export (use `uri_path`)
14+
* Fix historical typo in naming of `QuerySet` classes
15+
* [Add a PNG version of the logo](https://github.com/rdmorganiser/rdmo/pull/1361/commits/c21b7bafcf284ec7ac3b40b5c425fee207ddf461)
16+
17+
### Maintenance and Dependencies 🔧
18+
19+
* Removed dependency on `pytz` from management commands (#1382)
20+
* Refactor export tests and include tests code in coverage (#1319)
21+
* Update NodeJS version to 22 LTS (#1371)
222

323
## [RDMO 2.3.1](https://github.com/rdmorganiser/rdmo/compare/2.3.0...2.3.1) (May 16, 2025)
424

package-lock.json

Lines changed: 11 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,10 @@
1313
"type": "git",
1414
"url": "https://github.com/rdmorganiser/rdmo"
1515
},
16+
"engines": {
17+
"node": "22.16.x",
18+
"npm": "10.x"
19+
},
1620
"dependencies": {
1721
"@codemirror/lang-html": "^6.4.2",
1822
"@codemirror/lang-javascript": "^6.2.2",
@@ -54,7 +58,7 @@
5458
"eslint-plugin-react": "^7.37.2",
5559
"file-loader": "^6.2.0",
5660
"mini-css-extract-plugin": "^2.9.0",
57-
"sass": "^1.87.0",
61+
"sass": "^1.89.1",
5862
"sass-loader": "^16.0.0",
5963
"webpack": "^5.99.7",
6064
"webpack-cli": "^6.0.1",

pyproject.toml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ dependencies = [
6565

6666
[project.optional-dependencies]
6767
allauth = [
68-
"django-allauth[socialaccount,openid]>=64.1.0,<65.8.0",
68+
"django-allauth[socialaccount,openid]>=64.1.0,<65.10.0",
6969
]
7070
ci = [
7171
"rdmo[dev]",
@@ -229,13 +229,11 @@ parallel = true
229229

230230
[tool.coverage.report]
231231
omit = [
232-
"*/management/*",
232+
"*/management/commands/*",
233233
"*/migrations/*",
234-
"*/tests/*",
235234
]
236235
exclude_lines = [
237-
"raise Exception",
238-
"except ImportError:"
236+
"raise NotImplementedError"
239237
]
240238

241239
[tool.typos] # Ref: https://github.com/crate-ci/typos/blob/master/docs/reference.md

rdmo/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
__version__ = "2.3.1"
1+
__version__ = "2.3.2"

rdmo/accounts/templates/socialaccount/connections.html

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
{% extends 'core/page.html' %}
22
{% load i18n %}
3+
{% load static %}
4+
{% load accounts_tags %}
35

46
{% block page %}
57

@@ -28,8 +30,15 @@ <h2>{% trans 'Current connections' %}</h2>
2830

2931
<label for="id_account_{{ base_account.id }}">
3032
<input id="id_account_{{ base_account.id }}" type="radio" name="account" value="{{ base_account.id }}"/>
33+
34+
{% if base_account.provider == 'orcid' %}
35+
<a href="https://orcid.org/{{ base_account.uid }}" target="_blank">
36+
<img alt="ORCID logo" src="{% static 'accounts/img/orcid_16x16.png' %}" width="16" height="16" />
37+
https://orcid.org/{{ base_account.uid }}
38+
</a>
39+
{% else %}
3140
<span>{{account.get_brand.name}}</span>
32-
<span>({{ account }})</span>
41+
{% endif %}
3342
</label>
3443

3544
{% endwith %}
@@ -55,11 +64,14 @@ <h2>{% trans 'Current connections' %}</h2>
5564

5665
{% endif %}
5766

67+
{% get_inactive_providers as inactive_providers %}
68+
{% if inactive_providers %}
5869
<h2>{% trans 'Add an additional account' %}</h2>
5970

6071
<ul class="socialaccount_providers">
61-
{% include "socialaccount/snippets/provider_list.html" with process="connect" %}
72+
{% include "socialaccount/snippets/provider_list.html" with process="connect" socialaccount_providers=inactive_providers %}
6273
</ul>
74+
{% endif %}
6375

6476
{% include "socialaccount/snippets/login_extra.html" %}
6577

Lines changed: 27 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
{% load socialaccount %}
22
{% load static %}
33

4+
{% if not socialaccount_providers %}
45
{% get_providers as socialaccount_providers %}
6+
{% endif %}
57

68
{% for provider in socialaccount_providers %}
79

@@ -18,35 +20,46 @@
1820
{% endif %}
1921

2022
{% if provider.id == 'orcid' %}
23+
2124
<li class="socialaccount_provider_break">
2225
<a title="{{provider.name}}" class="socialaccount_provider {{provider.id}}"
2326
href="{% provider_login_url provider.id process=process scope=scope auth_params=auth_params %}">
2427
<img src="{% static 'accounts/img/orcid-signin.png' %}" alt="ORCID sign in" />
2528
</a>
2629
</li>
30+
2731
{% elif provider.id == 'openid_connect' %}
28-
{% if provider.app.provider_id == 'keycloak' %}
29-
<li class="socialaccount_provider_break">
30-
<a title="{{ provider.name }}" class="socialaccount_provider {{ provider.id }}"
31-
href="{% provider_login_url provider process=process scope=scope auth_params=auth_params %}">
32-
<img src="{% static 'accounts/img/keycloak_logo_200px.svg' %}" alt="Keycloak sign in" />
33-
</a>
34-
</li>
35-
{% else %}
36-
<li>
37-
<a title="{{provider.name}}" class="socialaccount_provider {{provider.id}}"
38-
href="{% provider_login_url provider process=process scope=scope auth_params=auth_params %}">
39-
{{ provider.name }}
40-
</a>
41-
</li>
32+
33+
{% if provider.app.provider_id == 'keycloak' %}
34+
<li class="socialaccount_provider_break">
35+
<a title="{{ provider.name }}" class="socialaccount_provider {{ provider.app.provider_id }}"
36+
href="{% provider_login_url provider process=process scope=scope auth_params=auth_params %}">
37+
<img src="{% static 'accounts/img/keycloak_logo_200px.svg' %}" alt="Keycloak sign in" />
38+
</a>
39+
</li>
40+
{% else %}
41+
<li>
42+
<a title="{{ provider.name }}" class="socialaccount_provider {{ provider.app.provider_id }}"
43+
href="{% provider_login_url provider process=process scope=scope auth_params=auth_params %}">
44+
{{ provider.name }}
45+
</a>
46+
</li>
4247
{% endif %}
4348

49+
4450
{% else %}
51+
4552
<li>
4653
<a title="{{provider.name}}" class="socialaccount_provider {{provider.id}}"
4754
href="{% provider_login_url provider.id process=process scope=scope auth_params=auth_params %}">
55+
{% if provider.id == 'dummy' %}
56+
<span class="fa fa-meh-o fa-2x"></span>
57+
{% else %}
4858
<span class="fa fa-{{provider.id}} fa-2x"></span>
59+
{% endif %}
4960
</a>
5061
</li>
62+
5163
{% endif %}
64+
5265
{% endfor %}

0 commit comments

Comments
 (0)