fix: prevent onSelect firing twice on Enter when dropdown is open (#1219)

* fix: only submit input as tag on Enter when dropdown closed

* fix: remove unuse code

* test: modify test case

Author: QDyanbing

src/SelectInput/Input.tsx

@@ -95,7 +95,13 @@ const Input = React.forwardRef<HTMLInputElement, InputProps>((props, ref) => {
     const { value: nextVal } = event.currentTarget;
 
     // Handle Enter key submission - referencing Selector implementation
-    if (key === 'Enter' && mode === 'tags' && !compositionStatusRef.current && onSearchSubmit) {
+    if (
+      key === 'Enter' &&
+      mode === 'tags' &&
+      !open &&
+      !compositionStatusRef.current &&
+      onSearchSubmit
+    ) {
       onSearchSubmit(nextVal);
     }
 

tests/Tags.test.tsx

@@ -140,6 +140,29 @@ describe('Select.Tags', () => {
     expectOpen(container, false);
   });
 
+  it('should trigger onSelect once when pressing Enter to select option in tags mode (dropdown open)', () => {
+    const handleSelect = jest.fn();
+    const { container } = render(
+      <Select
+        mode="tags"
+        open
+        showSearch
+        onSelect={handleSelect}
+        options={[
+          { label: 'opt1', value: 'opt1' },
+          { label: 'opt2', value: 'opt2' },
+        ]}
+      />,
+    );
+    fireEvent.change(container.querySelector('input'), { target: { value: 'op' } });
+    jest.runAllTimers();
+    keyDown(container.querySelector('input'), KeyCode.DOWN);
+    keyDown(container.querySelector('input'), KeyCode.ENTER);
+    jest.runAllTimers();
+    expect(handleSelect).toHaveBeenCalledTimes(1);
+    expect(handleSelect).toHaveBeenCalledWith('opt1', expect.anything());
+  });
+
   // Paste tests
   [
     {