Skip to content

Commit a16d41a

Browse files
committed
feat(notification): allow pull to update when tab is empty
Added the missing physics part.
1 parent b740e84 commit a16d41a

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

lib/features/notification/view/notification_page.dart

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,11 @@ class _NotificationPageState extends State<NotificationPage> with SingleTickerPr
3434
/// Flag indicating only show unread messages or not
3535
bool onlyShowUnread = false;
3636

37-
Widget _buildEmptyBody(BuildContext context) {
37+
Widget _buildEmptyBody(ScrollPhysics physics) {
3838
return Align(
3939
child: LayoutBuilder(
4040
builder: (context, constraints) => SingleChildScrollView(
41-
physics: const AlwaysScrollableScrollPhysics(),
41+
physics: physics,
4242
child: ConstrainedBox(
4343
constraints: BoxConstraints(minWidth: MediaQuery.sizeOf(context).width, minHeight: constraints.maxHeight),
4444
child: Center(
@@ -109,7 +109,7 @@ class _NotificationPageState extends State<NotificationPage> with SingleTickerPr
109109
header: const MaterialHeader(),
110110
onRefresh: () => context.read<NotificationBloc>().add(NotificationUpdateAllRequested()),
111111
childBuilder: (context, physics) => n.isEmpty
112-
? _buildEmptyBody(context)
112+
? _buildEmptyBody(physics)
113113
: ListView.separated(
114114
physics: physics,
115115
padding: edgeInsetsL12T4R12.add(context.safePadding()),
@@ -124,7 +124,7 @@ class _NotificationPageState extends State<NotificationPage> with SingleTickerPr
124124
header: const MaterialHeader(),
125125
onRefresh: () => context.read<NotificationBloc>().add(NotificationUpdateAllRequested()),
126126
childBuilder: (context, physics) => pm.isEmpty
127-
? _buildEmptyBody(context)
127+
? _buildEmptyBody(physics)
128128
: ListView.separated(
129129
physics: physics,
130130
padding: edgeInsetsL12T4R12.add(context.safePadding()),
@@ -139,7 +139,7 @@ class _NotificationPageState extends State<NotificationPage> with SingleTickerPr
139139
header: const MaterialHeader(),
140140
onRefresh: () => context.read<NotificationBloc>().add(NotificationUpdateAllRequested()),
141141
childBuilder: (context, physics) => bm.isEmpty
142-
? _buildEmptyBody(context)
142+
? _buildEmptyBody(physics)
143143
: ListView.separated(
144144
physics: physics,
145145
padding: edgeInsetsL12T4R12.add(context.safePadding()),

0 commit comments

Comments
 (0)