Skip to content

Commit d4a07cf

Browse files
mdonadonitiborsimko
authored andcommitted
fix(fixtures): encode all user secrets in base64 (#131)
Closes reanahub/reana-commons#455
1 parent 9477298 commit d4a07cf

1 file changed

Lines changed: 7 additions & 6 deletions

File tree

pytest_reana/fixtures.py

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -812,12 +812,13 @@ def no_db_user():
812812
@pytest.fixture
813813
def user_secrets():
814814
"""Test user secrets dictionary."""
815-
keytab_file = base64.b64encode(b"keytab file.")
816815
user_secrets = {
817-
"username": {"value": "reanauser", "type": "env"},
818-
"password": {"value": "1232456", "type": "env"},
819-
".keytab": {"value": keytab_file, "type": "file"},
816+
"username": {"value": b"reanauser", "type": "env"},
817+
"password": {"value": b"1232456", "type": "env"},
818+
".keytab": {"value": b"keytab file.", "type": "file"},
820819
}
820+
for secret in user_secrets.values():
821+
secret["value"] = base64.b64encode(secret["value"]).decode()
821822
return user_secrets
822823

823824

@@ -830,7 +831,7 @@ def kerberos_user_secrets():
830831
".keytab": {"value": b"keytab file", "type": "file"},
831832
}
832833
for secret in user_secrets.values():
833-
secret["value"] = base64.b64encode(secret["value"])
834+
secret["value"] = base64.b64encode(secret["value"]).decode()
834835
return user_secrets
835836

836837

@@ -855,7 +856,7 @@ def make_corev1_api_client_with_user_secrets(user_secrets):
855856
Should be used with one of the secret store fixtures.
856857
"""
857858
corev1_api_client = Mock()
858-
metadata = client.V1ObjectMeta(name=str(no_db_user.id_))
859+
metadata = client.V1ObjectMeta(name=f"reana-secretsstore-{no_db_user.id_}")
859860
metadata.annotations = {"secrets_types": "{}"}
860861
user_secrets_values = {}
861862
secrets_types = {}

0 commit comments

Comments
 (0)