feat(k8s): implement enabling of datastore interactive session side car

Author: etlstrauss

reana_workflow_controller/config.py

@@ -475,13 +475,21 @@ def _parse_interactive_sessions_environments(env_var):
     "REANA_RUNTIME_JOBS_KUBERNETES_TOLERATIONS"
 )
 """Tolerations for jobs"""
-
-REANA_DATASTORE_IMAGE = os.getenv(
-    "REANA_DATASTORE_IMAGE"
-)
-"""Image for datastore (s3) sidecar for interactive sessions"""
-
-REANA_DATASTORE_SECRET = os.getenv(
-    "REANA_DATASTORE_SECRET"
-)
-"""Optional secret for datastore (s3) sidecar for interactive sessions"""
+REANA_DATASTORE_ENABLED = os.getenv(
+    "REANA_DATASTORE_ENABLED"
+) == "true"
+"""Set datastore (s3) sidecar for interactive sessions enabled or disabled"""
+
+if(REANA_DATASTORE_ENABLED):
+    REANA_DATASTORE_IMAGE = os.getenv(
+        "REANA_DATASTORE_IMAGE"
+    )
+    """Optional Image for datastore (s3) sidecar for interactive sessions"""
+
+    REANA_DATASTORE_SECRET = os.getenv(
+        "REANA_DATASTORE_SECRET"
+    )
+    """Optional secret for datastore (s3) sidecar for interactive sessions"""
+else:
+    REANA_DATASTORE_IMAGE = ""
+    REANA_DATASTORE_SECRET = ""

reana_workflow_controller/k8s.py

@@ -33,6 +33,7 @@
     REANA_INGRESS_HOST,
     REANA_DATASTORE_SECRET,
     REANA_DATASTORE_IMAGE,
+    REANA_DATASTORE_ENABLED,
 )
 
 
@@ -87,11 +88,15 @@ def __init__(
         self._session_container = client.V1Container(
             name=self.deployment_name, image=self.image, env=[], volume_mounts=[], ports=[client.V1ContainerPort(container_port=self.port)]
         )
-        self._s3_container = client.V1Container(
-            name="datastore", image=REANA_DATASTORE_IMAGE, env=[], volume_mounts=[], ports=[], image_pull_policy="Always", lifecycle=[]
-        )
+        containers = [self._session_container]
+        if(REANA_DATASTORE_ENABLED):
+            self._s3_container = client.V1Container(
+                name="datastore", image=REANA_DATASTORE_IMAGE, env=[], volume_mounts=[], ports=[], image_pull_policy="Always", lifecycle=[]
+            )
+            containers.append(self._s3_container)
+
         self._pod_spec = client.V1PodSpec(
-            containers=[self._session_container, self._s3_container],
+            containers=containers,
             volumes=[],
             node_selector=REANA_RUNTIME_SESSIONS_KUBERNETES_NODE_LABEL,
             # Disable service discovery with env variables, so that the environment is
@@ -319,7 +324,7 @@ def add_user_secrets(self):
         all_env = user_secrets.get_env_secrets_as_k8s_spec()
         s3_env = []
         session_env = []
-        
+
         # Single for loop to split secrets
         for secret in all_env:
             secret_name = secret.get("name", "")
@@ -332,7 +337,8 @@ def add_user_secrets(self):
         self._session_container.env = session_env
 
         # mount s3 secretes
-        self._s3_container.env = s3_env
+        if(REANA_DATASTORE_ENABLED):
+            self._s3_container.env = s3_env
 
     def get_deployment_objects(self):
         """Return the alrady built Kubernetes objects."""
@@ -391,8 +397,9 @@ def build_interactive_jupyter_deployment_k8s_objects(
     deployment_builder.add_command_arguments(command_args)
     deployment_builder.add_reana_shared_storage()
     deployment_builder.add_image_pull_secrets()
-    deployment_builder.setup_s3_sidecar()
-    deployment_builder.setup_s3_storage()
+    if(REANA_DATASTORE_ENABLED):
+        deployment_builder.setup_s3_sidecar()
+        deployment_builder.setup_s3_storage()
     if cvmfs_repos:
         deployment_builder.add_cvmfs_repo_mounts(cvmfs_repos)
     if expose_secrets: