fix: add typecheck step to the build to catch compilation errors

This fix adds typecheck script which runs `tsc --noEmit` to verify there
is no compilation errors. This would catch errors if extension's code
is using not existing API.

Signed-off-by: Denis Golovin <dgolovin@redhat.com>

Author: dgolovin

package.json

@@ -36,13 +36,14 @@
   "scripts": {
     "generate:registry-authorizer": "npx openapi-typescript src/rh-api/registry-authorizer-schema.json -o src/rh-api/gen/registry-authorizer.d.ts",
     "generate:subscription": "npx openapi-typescript src/rh-api/subscription-schema.json -o src/rh-api/gen/subscription.d.ts",
-    "build": "pnpm generate:subscription && pnpm generate:registry-authorizer && vite build && node ./scripts/build.cjs",
+    "build": "pnpm generate:subscription && pnpm generate:registry-authorizer && pnpm typecheck && vite build && node ./scripts/build.cjs",
     "watch": "vite build -w",
     "format:check": "prettier --end-of-line auto --cache --check \"{src,types,scripts}/**/*.{ts,js}\"",
     "format:fix": "prettier --cache --write \"{src,types,scripts}/**/*.{ts,js}\"",
     "lint:clean": "rimraf .eslintcache",
     "lint:fix": "node --max-old-space-size=6144 node_modules/eslint/bin/eslint.js --cache . --cache-strategy content --fix --ext js,ts",
     "lint:check": "node --max-old-space-size=6144 node_modules/eslint/bin/eslint.js --cache . --cache-strategy content --ext js,ts",
+    "typecheck": "tsc --noEmit",
     "test": "vitest run --coverage",
     "test:all": "pnpm test && pnpm test:e2e",
     "test:e2e:setup": "playwright install chromium && xvfb-maybe --auto-servernum --server-args='-screen 0 1280x960x24' --",

src/extension.ts

@@ -93,10 +93,13 @@ function removeRegistry(serverUrl: string = REGISTRY_REDHAT_IO): void {
 
 async function createOrReuseRegistryServiceAccount(): Promise<void> {
   const currentSession = await signIntoRedHatDeveloperAccount();
-  const accessTokenJson = parseJwt(currentSession!.accessToken);
+  if (!currentSession) {
+    throw new Error('Red Hat sign-in is required to configure the container registry.');
+  }
+  const accessTokenJson = parseJwt(currentSession.accessToken);
   const { serviceAccountsApiV1: saApiV1 } = new ContainerRegistryAuthorizerClient({
     BASE: 'https://access.redhat.com/hydra/rest/terms-based-registry',
-    TOKEN: currentSession!.accessToken,
+    TOKEN: currentSession.accessToken,
   });
   let { data: serviceAccount } = await saApiV1.serviceAccountByNameUsingGet1(
     'podman-desktop',
@@ -116,20 +119,22 @@ async function createOrReuseRegistryServiceAccount(): Promise<void> {
       throw new Error(`Can't create registry authorizer service account.`);
     }
   }
-
   await createRegistry(
-    serviceAccount!.credentials!.username!,
-    serviceAccount!.credentials!.password!,
+    serviceAccount.credentials!.username!,
+    serviceAccount.credentials!.password!,
     currentSession.account.label,
   );
 }
 
 async function createOrReuseActivationKey(connection: extensionApi.ProviderContainerConnection): Promise<void> {
   const currentSession = await signIntoRedHatDeveloperAccount();
-  const accessTokenJson = parseJwt(currentSession!.accessToken);
+  if (!currentSession) {
+    throw new Error('Red Hat sign-in is required to configure the subscription activation key.');
+  }
+  const accessTokenJson = parseJwt(currentSession.accessToken);
   const client = new SubscriptionManagerClient({
     BASE: 'https://console.redhat.com/api/rhsm/v2',
-    TOKEN: currentSession!.accessToken,
+    TOKEN: currentSession.accessToken,
   });
 
   const { error: showKeyErr } = await client.activationKey.showActivationKey('podman-desktop');