Skip to content

Commit 5f5ff39

Browse files
openshift-cherrypick-robotlhite8041themr0c
authored
[release-1.9] RHDHBUGS-2007: Do not use "foo" (#1820)
Co-authored-by: BigEars <lhite@redhat.com> Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
1 parent 9a22bae commit 5f5ff39

9 files changed

+41
-41
lines changed

modules/configuring-a-proxy/proc-configuring-proxy-in-helm-deployment.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ Where,
3030

3131
`<http_proxy_url>`:: Denotes a variable that you must replace with the HTTP proxy URL.
3232
`<https_proxy_url>`:: Denotes a variable that you must replace with the HTTPS proxy URL.
33-
`<no_proxy_settings>`:: Denotes a variable that you must replace with comma-separated URLs, which you want to exclude from proxying, for example, `foo.com,baz.com`.
33+
`<no_proxy_settings>`:: Denotes a variable that you must replace with comma-separated URLs, which you want to exclude from proxying, for example, `__<example1>__.com,__<example2>__.com`.
3434
+
3535
.Example: Setting proxy variables using Helm Chart
3636

modules/customizing-the-appearance/proc-configuring-dynamic-plugin-menuitem.adoc

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,13 @@ Configure a dynamic plugin menu item using the following step:
99

1010
* In the `{my-app-config-file}` file, update the `menuItems` section of your _<plugin_name>_ plugin. For example:
1111
+
12-
[source,yaml]
12+
[source,yaml,subs="+quotes"]
1313
----
1414
dynamicPlugins:
1515
frontend:
1616
_<plugin_name>_:
1717
menuItems:
18-
<menu_item_name>:
18+
__<menu_item_name>__:
1919
icon: # home | group | category | extension | school | _<my_icon>_
2020
title: _<plugin_page_title>_
2121
priority: 10
@@ -50,18 +50,18 @@ Enter a unique name in the main sidebar navigation for either a standalone menu
5050
Enter `true` to display the menu item in the sidebar.
5151

5252
+
53-
[source,yaml,subs="+attributes"]
53+
[source,yaml,subs="+quotes,+attributes"]
5454
----
5555
dynamicPlugins:
5656
frontend:
5757
_<package_name>_:
5858
dynamicRoutes:
59-
- path: /my-plugin
59+
- path: __</my-plugin>__
6060
module: CustomModule
61-
importName: FooPluginPage
61+
importName: __<my-plugin>__PluginPage
6262
menuItem:
63-
icon: fooIcon
64-
text: Foo Plugin Page
63+
icon: # home | group | category | extension | school | _<my_icon>_
64+
text: __<my-plugin label>__
6565
menuItems:
6666
my-plugin:
6767
priority: 10

modules/dynamic-plugins/proc-binding-to-existing-plugins.adoc

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,11 @@
55

66
You can bind to existing plugins and their routes, and declare new targets sourced from dynamic plugins as shown in the following `routeBindings` configuration:
77

8-
[source,yaml]
8+
[source,yaml,subs="+quotes"]
99
----
1010
# dynamic-plugins-config.yaml
1111
plugins:
12-
- plugin: <plugin_path_or_url>
12+
- plugin: __<plugin_path_or_url>__
1313
disabled: false
1414
pluginConfig:
1515
dynamicPlugins:
@@ -18,15 +18,15 @@ plugins:
1818
routeBindings:
1919
targets: # A new bind target
2020
# (Optional): Defaults to importName. Explicit name of the plugin that exposes the bind target.
21-
- name: barPlugin
21+
- name: __<plugin_name>__Plugin
2222
# (Required): Explicit import name that reference a BackstagePlugin<{}> implementation.
23-
importName: barPlugin
23+
importName: __<plugin_key>__Plugin
2424
# # (Optional): Same as key in `scalprum.exposedModules` key in the `package.json` file of the plugin.
2525
module: CustomModule
2626
bindings:
27-
- bindTarget: "barPlugin.externalRoutes" # (Required): One of the supported or imported bind targets
27+
- bindTarget: "__<plugin_name>__Plugin.externalRoutes" # (Required): One of the supported or imported bind targets
2828
bindMap: # A required map of route bindings similar to `bind` function options
29-
headerLink: "fooPlugin.routes.root"
29+
headerLink: "__<plugin_name>__Plugin.routes.root"
3030
----
3131

3232
To configure `routeBindings`, complete the following steps:

modules/dynamic-plugins/proc-customizing-entity-page.adoc

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ The available mount points include the following:
101101

102102
[NOTE]
103103
====
104-
Mount points within catalog such as `entity.page.` are rendered as tabs and become visible only if at least one plugin contributes to them, or if they can render static content.
104+
Mount points within a catalog such as `entity.page.` are rendered as tabs and become visible only if at least one plugin contributes to them, or if they can render static content.
105105
====
106106

107107
Each `entity.page.` mount point contains the following variations:
@@ -111,20 +111,20 @@ Each `entity.page.` mount point contains the following variations:
111111

112112
The following is an example of the overall configuration structure of a mount point:
113113

114-
[source,yaml]
114+
[source,yaml,subs="+quotes"]
115115
----
116116
# dynamic-plugins-config.yaml
117117
plugins:
118-
- plugin: <plugin_path_or_url>
118+
- plugin: __<plugin_path_or_url>__
119119
disabled: false
120120
pluginConfig:
121121
dynamicPlugins:
122122
frontend:
123123
my-plugin: # The plugin package name
124124
mountPoints: # (Optional): Uses existing mount points
125-
- mountPoint: <mountPointName>/[cards|context]
125+
- mountPoint: __<mountPointName>__/[cards|context]
126126
module: CustomModule
127-
importName: FooPluginPage
127+
importName: __<pluginName>__PluginPage
128128
config: # (Optional): Allows you to pass additional configuration to the component
129129
layout: {} # Used only in `/cards` type which renders visible content
130130
# Use only in `/cards` type which renders visible content. `if` is passed to `<EntitySwitch.Case if={<here>}`.
@@ -162,11 +162,11 @@ export type SimpleDialogProps = {
162162

163163
You can configure the context menu entry using the props configuration entry for the mount point. The `title` and `icon` properties sets the text and icon of the menu item. You can use any system icon or icon added through a dynamic plugin. The following is an example configuration:
164164

165-
[source,yaml]
165+
[source,yaml,subs="+quotes"]
166166
----
167167
# dynamic-plugins-config.yaml
168168
plugins:
169-
- plugin: <plugin_path_or_url>
169+
- plugin: __<plugin_path_or_url>__
170170
disabled: false
171171
pluginConfig:
172172
dynamicPlugins:

modules/dynamic-plugins/proc-customizing-sidebar-menu-items.adoc

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,23 +5,23 @@
55

66
You can customize the order and parent-child relationships of plugin menu items in the main sidebar navigation using the menu items configuration as shown in the following example:
77

8-
[source,yaml]
8+
[source,yaml,subs="+quotes"]
99
----
1010
# dynamic-plugins-config.yaml
1111
plugins:
12-
- plugin: <plugin_path_or_url>
12+
- plugin: __<plugin_path_or_url>__
1313
disabled: false
1414
pluginConfig:
1515
dynamicPlugins:
1616
frontend:
1717
my-plugin: # The plugin package name
1818
menuItems:
1919
# The unique name in the main sidebar navigation (for example, either a standalone menu item or a parent menu item)
20-
<menu_item_name>:
20+
__<menu_item_name>__:
2121
# (Optional): The icon for the menu item, which refers to a Backstage system icon
22-
icon: fooIcon
22+
icon: __<icon_name>__Icon
2323
# (Optional): The display title of the menu item
24-
title: Foo Plugin Page
24+
title: __<plugin_name>__ Plugin Page
2525
# (Optional): The order in which menu items appear. The default priority is `0`.
2626
priority: 10
2727
# (Optional): Defines the parent menu item to nest the current item under

modules/dynamic-plugins/proc-defining-dynamic-routes-for-new-plugin-pages.adoc

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,12 @@
77
. Define each route by specifying a unique `path` and, if needed, an `importName` if it is different from the `default` export.
88
. Expose additional routes in a dynamic plugin by configuring `dynamicRoutes` as shown in the following example:
99
+
10-
[source,yaml]
10+
[source,yaml,subs="+quotes"]
1111
+
1212
----
1313
# dynamic-plugins-config.yaml
1414
plugins:
15-
- plugin: <plugin_path_or_url>
15+
- plugin: __<plugin_path_or_url>__
1616
disabled: false
1717
pluginConfig:
1818
dynamicPlugins:
@@ -24,11 +24,11 @@ plugins:
2424
# (Optional): The set of assets to access within the plugin. If not specified, the system uses the `PluginRoot` module.
2525
module: CustomModule
2626
# (Optional): The component name as a standalone page. If not specified, the system uses the `default` export.
27-
importName: FooPluginPage
27+
importName: __<my-plugin>__PluginPage
2828
# Allows you to extend the main sidebar navigation and point to a new route.
2929
menuItem:
30-
icon: fooIcon
31-
text: Foo Plugin Page
30+
icon: # home | group | category | extension | school | _<my_icon>_
31+
text: __<my-plugin label>__
3232
enabled: false
3333
config: # (Optional): Passes `props` to a custom sidebar item
3434
props: ...
@@ -51,11 +51,11 @@ export type MySidebarItemProps = {
5151
----
5252

5353
.Example specifying a custom `SidebarItem` component:
54-
[source,yaml]
54+
[source,yaml,subs="+quotes"]
5555
----
5656
# dynamic-plugins-config.yaml
5757
plugins:
58-
- plugin: <plugin_path_or_url>
58+
- plugin: __<plugin_path_or_url>__
5959
disabled: false
6060
pluginConfig:
6161
dynamicPlugins:

modules/dynamic-plugins/proc-export-third-party-plugins-rhdh.adoc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,8 @@ You can add a `scalprum` section to the `package.json` file. For example:
8989
"scalprum": {
9090
"name": "custom-package-name",
9191
"exposedModules": {
92-
"FooModuleName": "./src/foo.ts",
93-
"BarModuleName": "./src/bar.ts"
92+
"BazModuleName": "./src/baz.ts",
93+
"QuxModuleName": "./src/qux.ts"
9494
// Define multiple modules here, with each exposed as a separate entry point in the Webpack container.
9595
}
9696
}

modules/dynamic-plugins/proc-extending-internal-icon-catalog.adoc

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,22 +8,22 @@ You can use the internal catalog to fetch icons for configured routes with sideb
88
.Procedure
99
* Add a custom icon to the internal icon catalog for use in the menu item of a plugin by using the `appIcons` configuration as shown in the following example:
1010

11-
[source,yaml]
11+
[source,yaml,subs="+quotes"]
1212
----
1313
# dynamic-plugins-config.yaml
1414
plugins:
15-
- plugin: <plugin_path_or_url>
15+
- plugin: __<plugin_path_or_url>__
1616
disabled: false
1717
pluginConfig:
1818
dynamicPlugins:
1919
frontend:
2020
my-plugin: # The plugin package name
2121
appIcons:
22-
- name: fooIcon # The icon catalog name
22+
- name: __<catalogName>__ # The icon catalog name
2323
# (Optional): The set of assets to access within the plugin. If not specified, the system uses the `PluginRoot` module.
2424
module: CustomModule
2525
# (Optional): The actual component name to be rendered as a standalone page. If not specified, the system uses the `default` export.
26-
importName: FooIcon
26+
importName: __<CustomIcon>__
2727
----
2828

2929
[NOTE]

modules/dynamic-plugins/ref-community-plugins-migration.template.adoc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
// This page is generated! Do not edit the .adoc file, but instead run rhdh-supported-plugins.sh to regen this page from the latest plugin metadata.
55

66
:_mod-docs-content-type: REFERENCE
7-
[id="ref-community-plugins-migration_{context}"]
8-
= Community plugins migration to the GitHub Container Registry
7+
[id="ref-community-plugins-migration-template_{context}"]
8+
= Template for community plugins migration to the GitHub Container Registry
99

1010
[IMPORTANT]
1111
====

0 commit comments

Comments
 (0)