[RHDHBUGS-2954]: Fix CQA/build-orchestrator infinite recursion (#2059)

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Author: themr0c

build/scripts/build-orchestrator.js

@@ -661,9 +661,13 @@ async function main() {
     lycheeResult.errors = classifyErrors(lycheeResult.output, patterns);
   }
 
-  // Run CQA content quality assessment
-  console.log('\nRunning CQA content quality assessment...');
-  const cqaResult = await runCqa(repoRoot, args.verbose);
+  // Run CQA content quality assessment (skip when invoked from CQA-14 to avoid recursion)
+  const cqaResult = process.env.CQA_RUNNING
+    ? { status: 'passed', duration: 0, output: '', stats: { total: 0, pass: 0, fail: 0 } }
+    : await (async () => {
+        console.log('\nRunning CQA content quality assessment...');
+        return runCqa(repoRoot, args.verbose);
+      })();
 
   const totalDuration = Math.round((Date.now() - totalStart) / 1000);
 

build/scripts/cqa/checks/cqa-14-no-broken-links.js

@@ -90,10 +90,12 @@ function getLycheeIssues(root) {
 
   try {
     // Run build orchestrator (builds fresh HTML + runs lychee with remapping)
+    // Set CQA_RUNNING to prevent build-orchestrator from running CQA again (recursion)
     execFileSync('node', ['build/scripts/build-orchestrator.js', '-b', 'main'], { // NOSONAR — fixed args, no user input
       cwd: root,
       stdio: 'pipe',
       timeout: 600000, // 10 minutes
+      env: { ...process.env, CQA_RUNNING: '1' },
     });
   } catch {
     // Build may exit non-zero if lychee finds broken links — that's expected