test(notification): wait for page to load (#2248)

* test(notification): wait for page to load

* use waitForLoad

Author: jrichter1

workspaces/backstage/e2e-tests/support/pages/notifications.ts

@@ -12,18 +12,15 @@ export class NotificationPage {
 
   async clickNotificationsNavBarItem() {
     await this.uiHelper.openSidebar("Notifications");
-    await expect(
-      this.page.getByTestId("loading-indicator").getByRole("img"),
-    ).toHaveCount(0);
+    await this.uiHelper.verifyHeading("Notifications");
+    await this.uiHelper.waitForLoad();
   }
 
   async notificationContains(text: string | RegExp) {
     await this.page.getByLabel("rows").click();
     // always expand the notifications table to show as many notifications as possible
     await this.page.getByRole("option", { name: "20" }).click();
-    await expect(
-      this.page.getByTestId("loading-indicator").getByRole("img"),
-    ).toHaveCount(0);
+    await this.uiHelper.waitForLoad();
     const row = this.page.locator(`tr`, { hasText: text }).first();
     await expect(row).toHaveCount(1);
   }
@@ -38,9 +35,7 @@ export class NotificationPage {
     await expect(
       this.page.getByRole("table").filter({ hasText: "Rows per page" }),
     ).toBeVisible();
-    await expect(
-      this.page.getByTestId("loading-indicator").getByRole("img"),
-    ).toHaveCount(0);
+    await this.uiHelper.waitForLoad();
   }
 
   async saveSelected() {
@@ -49,17 +44,13 @@ export class NotificationPage {
       .getByTitle("Save selected for later")
       .getByRole("button")
       .click();
-    await expect(
-      this.page.getByTestId("loading-indicator").getByRole("img"),
-    ).toHaveCount(0);
+    await this.uiHelper.waitForLoad();
   }
 
   async viewSaved() {
     await this.page.getByLabel("View").click();
     await this.page.getByRole("option", { name: "Saved" }).click();
-    await expect(
-      this.page.getByTestId("loading-indicator").getByRole("img"),
-    ).toHaveCount(0);
+    await this.uiHelper.waitForLoad();
   }
 
   async markNotificationAsRead(text: string) {
@@ -77,18 +68,14 @@ export class NotificationPage {
     await this.page
       .getByRole("option", { name: "Read notifications", exact: true })
       .click();
-    await expect(
-      this.page.getByTestId("loading-indicator").getByRole("img"),
-    ).toHaveCount(0);
+    await this.uiHelper.waitForLoad();
   }
 
   async viewUnRead() {
     await this.page.getByLabel("View").click();
     await this.page
       .getByRole("option", { name: "Unread notifications", exact: true })
       .click();
-    await expect(
-      this.page.getByTestId("loading-indicator").getByRole("img"),
-    ).toHaveCount(0);
+    await this.uiHelper.waitForLoad();
   }
 }