Verify during the build that tools download info is correct. (#836)

Author: sudhirverma

.gitignore

@@ -3,4 +3,5 @@ node_modules
 .vscode-test/
 *.vsix
 coverage/
-toFile
+toFile
+cache

.vscode/settings.json

@@ -7,5 +7,6 @@
         "out": true // set this to false to include "out" folder in search results
     },
     // Turn off tsc task auto detection since we have the necessary tasks as npm scripts
-    "typescript.tsc.autoDetect": "off"
+    "typescript.tsc.autoDetect": "off",
+    "debug.node.autoAttach": "off"
 }

build/check-copyright.ts

@@ -12,7 +12,7 @@ walker('.').filterDir((dir: string) => dir !== 'node_modules' && dir !== '.vscod
   if (file.endsWith('.ts')) {
     const result = await WatchUtil.grep(file, /Copyright \(c\)/);
     if (!result) {
-      if(!failed) {
+      if (!failed) {
         failed = true;
         console.log('Files without copyright comment:');
       }

build/verify-tools.ts

@@ -0,0 +1,54 @@
+/*-----------------------------------------------------------------------------------------------
+ *  Copyright (c) Red Hat, Inc. All rights reserved.
+ *  Licensed under the MIT License. See LICENSE file in the project root for license information.
+ *-----------------------------------------------------------------------------------------------*/
+
+'use strict';
+
+import hasha = require('hasha');
+import mkdirp = require('mkdirp');
+import fs = require('fs-extra');
+import path = require("path");
+import cp = require('child_process');
+import configData = require('../src/tools.json');
+import os = require('os');
+import { DownloadUtil } from '../src/util/download';
+
+async function verifyTools() {
+  for (const key in configData) {
+    for (const OS in configData[key].platform) {
+      const targetFolder =  path.resolve(os.tmpdir(), OS);
+      await downloadFileAndCreateSha256(targetFolder, configData[key].platform[OS].dlFileName, configData[key].platform[OS].url, configData[key].platform[OS].sha256sum);
+    }
+  }
+}
+
+async function downloadFileAndCreateSha256(targetFolder: string, fileName: string, reqURL: string, sha256sum: string) {
+  if (!fs.existsSync(targetFolder)) {
+    await mkdirp.sync(targetFolder);
+  }
+  const currentFile = path.join(targetFolder, fileName);
+  console.log(`${currentFile} download started from ${reqURL}`)
+  await DownloadUtil.downloadFile(reqURL, currentFile, (current) => console.log(current + '%'));
+  const currentSHA256 = await hasha.fromFile(currentFile, {algorithm: 'sha256'});;
+  if (currentSHA256 === sha256sum) {
+    console.log( `[INFO] ${currentFile} is downloaded and sha256 is correct`);
+  } else {
+    throw Error(`${currentFile} is downloaded and sha256 is not correct`);
+  }
+}
+
+const fileCheckRegex = /\w*tools.json/;
+cp.exec('git diff --name-only master..HEAD', async (error, stdout, stderr) => {
+  if (error) {
+    throw error;
+  }
+  console.log('The changed files:');
+  console.log(stdout);
+  if (fileCheckRegex.test(stdout)) {
+    console.log('tools.json is changed, starting download verification')
+    await verifyTools();
+  } else {
+    console.log('tools.json is not changed, skipping download verification')
+  }
+});

package-lock.json

@@ -632,12 +632,13 @@
   },
   "extensionDependencies": [],
   "scripts": {
+    "verify": "node ./out/build/verify-tools.js",
     "vscode:prepublish": "npm run compile",
     "compile": "tsc -p ./",
     "watch": "tsc -watch -p ./",
     "postinstall": "node ./node_modules/vscode/bin/install",
     "clean": "rm -rf out || rmdir out /s /q",
-    "test": "npm run clean && npm run compile && node ./node_modules/vscode/bin/test",
+    "test": "npm run clean && npm run compile && npm run verify && node ./node_modules/vscode/bin/test",
     "update-deps": "node_modules/.bin/ncu --upgrade --loglevel verbose --packageFile package.json && npm update",
     "coverage:upload": "codecov -f coverage/coverage-final.json",
     "build": "npm run clean && tslint -p tslint.json && npm run compile"
@@ -685,6 +686,7 @@
     "git-transport-protocol": "^0.1.0",
     "hasha": "^5.0.0",
     "js-yaml": "^3.13.1",
+    "mkdirp": "^0.5.1",
     "open": "^6.2.0",
     "request": "^2.88.0",
     "request-progress": "^3.0.0",

package.json

@@ -113,7 +113,6 @@ async function initNamespaceName(node: ClusterExplorerV1.ClusterExplorerResource
     if (kubectl.available) {
         const result = await kubectl.api.invokeCommand('config view -o json');
         const config = JSON.parse(result.stdout);
-        const ctxName = config["current-context"];
         const currentContext = (config.contexts || []).find((ctx) => ctx.name === node.name);
         if (!currentContext) {
             return "";
@@ -125,7 +124,7 @@ async function initNamespaceName(node: ClusterExplorerV1.ClusterExplorerResource
 async function customizeAsync(node: ClusterExplorerV1.ClusterExplorerResourceNode, treeItem: vscode.TreeItem): Promise<void> {
     if ((node as any).nodeType === 'context') {
         lastNamespace = await initNamespaceName(node);
-        if(isOpenShift()) {
+        if (isOpenShift()) {
             treeItem.iconPath = vscode.Uri.file(path.join(__dirname, "../../images/context/cluster-node.png"));
         }
     }

src/extension.ts

@@ -36,7 +36,6 @@ export class Application extends OpenShiftItem {
             "Select Application to delete");
         if (application) {
             const appName = application.getName();
-            const projName = application.getParent().getName();
             const value = await window.showWarningMessage(`Do you want to delete Application '${appName}?'`, 'Yes', 'Cancel');
             if (value === 'Yes') {
                 return Progress.execFunctionWithProgress(`Deleting the Application '${appName}'`, () => Application.odo.deleteApplication(application))

src/openshift/application.ts

@@ -9,7 +9,6 @@ import { Component } from '../openshift/component';
 import { V1ServicePort } from '@kubernetes/client-node';
 import { OpenShiftItem } from './openshiftItem';
 import { Progress } from "../util/progress";
-import { URL } from 'url';
 import open = require('open');
 import { ChildProcess } from 'child_process';