Skip to content

Commit 0deebe9

Browse files
committed
Why is the dependency on vscode-kubernetes added during release? #3091
Fixes: #3091 Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
1 parent 75353a7 commit 0deebe9

File tree

3 files changed

+5
-2
lines changed

3 files changed

+5
-2
lines changed

build/install-vscode.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,8 @@ void testElectron.downloadAndUnzipVSCode().then((executable: string) => {
2828

2929
// Install extensions that openshift-toolkit depends on
3030
const extensionsToInstall = [
31-
'redhat.vscode-redhat-account'
31+
'redhat.vscode-redhat-account',
32+
'ms-kubernetes-tools.vscode-kubernetes-tools'
3233
];
3334

3435
const extensionRootPath = path.resolve(__dirname, '..', '..');

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1900,7 +1900,8 @@
19001900
]
19011901
},
19021902
"extensionDependencies": [
1903-
"redhat.vscode-redhat-account"
1903+
"redhat.vscode-redhat-account",
1904+
"ms-kubernetes-tools.vscode-kubernetes-tools"
19041905
],
19051906
"__metadata": {
19061907
"id": "8fea1f1f-b45c-4eea-b479-3a92c6e697d3",

test/unit/extension.test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,7 @@ suite('openshift toolkit Extension', () => {
105105

106106
test('Extension should be present', () => {
107107
assert.ok(vscode.extensions.getExtension('redhat.vscode-openshift-connector'));
108+
assert.ok(vscode.extensions.getExtension('ms-kubernetes-tools.vscode-kubernetes-tools'));
108109
});
109110

110111
test('should register all extension commands declared commands in package descriptor', async function() {

0 commit comments

Comments
 (0)