Skip to content

Commit 0e0a433

Browse files
committed
Add a new panel for all OpenShift commands
It's a webview, since we need to use either a treeview or webview for all panels. It wraps xtermjs, the same library VS Code uses for its terminal. It exposes an API for interacting with the terminal multiplexer, as well as with the individual running processes. For example, we can run `odo dev` and update the UI (like we were doing before this PR). What's missing: - [ ] copy/paste - [ ] I synchronize most of the terminal settings with the VS Code ones, but there may be some I missed - [ ] reordering the tabs (I think we should gauge interest and save this for a future PR) - [ ] tab bar scrolling (supposedly the Material UI component comes with this built it, but it wasn't working when I tested it) Signed-off-by: David Thompson <davthomp@redhat.com>
1 parent 3a18ed6 commit 0e0a433

28 files changed

+9503
-3564
lines changed

.editorconfig

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,9 @@ insert_final_newline = true
1919
[*.md]
2020
trim_trailing_whitespace = false
2121

22+
[**webpack.config.js]
23+
indent_size = 2
24+
2225
[./package.json]
2326
indent_style = tab
2427
indent_size = 4

.eslintignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,5 @@ src/webview/devfile-registry
1717
src/webview/welcome
1818
src/webview/git-import
1919
src/webview/helm-chart
20+
src/webview/openshift-terminal/webpack.config.js
2021
test/sandbox-registration

.eslintrc

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,10 @@
1616
"parserOptions": {
1717
"ecmaVersion": 2018,
1818
"comment": true,
19-
"project": "./tsconfig.json",
19+
"project": [
20+
"./tsconfig.json",
21+
"./src/webview/*/app/tsconfig.json"
22+
],
2023
"sourceType": "module"
2124
},
2225
"plugins": [
@@ -101,7 +104,8 @@
101104
"radix": 2,
102105
"no-trailing-spaces": "error",
103106
"@typescript-eslint/prefer-regexp-exec": 0,
104-
"quotes": [ "error", "single"]
107+
"quotes": [ "error", "single"],
108+
"@typescript-eslint/no-unused-vars": [ "error", { "vars": "local", "args": "none" }]
105109
},
106110
"overrides": [
107111
{

.nvmrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
v16.13.2
1+
16.17

0 commit comments

Comments
 (0)