Skip to content

Commit 592e9ff

Browse files
committed
Add a new panel for all OpenShift commands
It's a webview, since we need to use either a treeview or webview for all panels. It wraps xtermjs, the same library VS Code uses for its terminal. It exposes an API for interacting with the terminal multiplexer, as well as with the individual running processes. For example, we can run `odo dev` and update the UI (like we were doing before this PR). What's missing: - [ ] copy/paste - [ ] I synchronize most of the terminal settings with the VS Code ones, but there may be some I missed - [ ] reordering the tabs (I think we should gauge interest and save this for a future PR) - [ ] tab bar scrolling (supposedly the Material UI component comes with this built it, but it wasn't working when I tested it) Signed-off-by: David Thompson <davthomp@redhat.com>
1 parent 06865f4 commit 592e9ff

28 files changed

+9492
-3562
lines changed

.editorconfig

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@ trim_trailing_whitespace = false
2121

2222
[Jenkinsfile]
2323
indent_size = 2
24+
[**webpack.config.js]
25+
indent_size = 2
2426

2527
[./package.json]
2628
indent_style = tab

.eslintignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,5 @@ src/webview/devfile-registry
1717
src/webview/welcome
1818
src/webview/git-import
1919
src/webview/helm-chart
20+
src/webview/openshift-terminal/webpack.config.js
2021
test/sandbox-registration

.eslintrc

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,10 @@
1616
"parserOptions": {
1717
"ecmaVersion": 2018,
1818
"comment": true,
19-
"project": "./tsconfig.json",
19+
"project": [
20+
"./tsconfig.json",
21+
"./src/webview/*/app/tsconfig.json"
22+
],
2023
"sourceType": "module"
2124
},
2225
"plugins": [

0 commit comments

Comments
 (0)