fix typos and add error warning (#1139)

* fix typos and add error warning
* replace showErrorMessage with throw new Error()

Author: mohitsuman

src/odo.ts

@@ -1125,7 +1125,7 @@ export class OdoImpl implements Odo {
         const result2 = await this.execute(getPreviosOdoResourceNames('ServiceInstance'), __dirname, false);
         const sis = result2.stdout.split('\n');
         if ((result2.stdout !== '' && sis.length > 0) || (result1.stdout !== '' && dcs.length > 0))  {
-            const choice = await window.showWarningMessage(`Some of resources in cluster must be updated to work with latest release of OpenShift Connector Extension.`, 'Update', 'Don\'t show it again', 'Help', 'Cancel');
+            const choice = await window.showWarningMessage(`Some of the resources in cluster must be updated to work with latest release of OpenShift Connector Extension.`, 'Update', 'Don\'t show it again', 'Help', 'Cancel');
             if (choice === 'Help') {
                 open('https://github.com/redhat-developer/vscode-openshift-tools/wiki/Migration-to-v0.1.0');
                 this.subject.next(new OdoEventImpl('changed', this.getClusters()[0]));

src/openshift/component.ts

@@ -300,7 +300,7 @@ export class Component extends OpenShiftItem {
             if (undeployRequired) {
                 let choice: string;
                 do {
-                    choice = await window.showWarningMessage('This Component must be undeployed before new version is pushed, because it was created and deployed with previous version ot the extension.', 'Undeploy', 'Help', 'Cancel');
+                    choice = await window.showWarningMessage('This Component must be undeployed before new version is pushed, because it was created and deployed with previous version of the extension.', 'Undeploy', 'Help', 'Cancel');
                     switch (choice) {
                         case 'Undeploy':
                             await Component.undeploy(component);
@@ -562,11 +562,9 @@ export class Component extends OpenShiftItem {
         const componentJson = JSON.parse(componentResult.stdout).items[0];
         const componentType = componentJson.metadata.annotations['app.kubernetes.io/component-source-type'];
         if (componentType === ComponentType.BINARY) {
-            window.showInformationMessage('Import for binary OpenShift Components is not supported.');
-            return;
+            return 'Import for binary OpenShift Components is not supported.';
         } else if (componentType !== ComponentType.GIT && componentType !== ComponentType.LOCAL) {
-            window.showInformationMessage(`Cannot import unknown Component type '${componentType}'.`);
-            return;
+            throw new Error(`Cannot import unknown Component type '${componentType}'.`);
         }
 
         const workspaceFolder = await selectWorkspaceFolder();
@@ -578,7 +576,7 @@ export class Component extends OpenShiftItem {
                 //  annotations:
                 //      app.kubernetes.io/component-source-type: binary
                 //      app.openshift.io/vcs-uri: 'file:///helloworld.war'
-                // verify if local file exists and ask for correct location
+                // not supported yet
 
                 // metadata:
                 //  annotations:
@@ -589,14 +587,7 @@ export class Component extends OpenShiftItem {
                 //  annotations:
                 //      app.kubernetes.io/component-source-type: git
                 //      app.kubernetes.io/url: 'https://github.com/dgolovin/nodejs-ex'
-                // if (componentJson.annotations['app.kubernetes.io/component-source-type'] === ComponentType.BINARY) {
-                //     const binaryUri = Uri.parse(componentJson.annotations['app.openshift.io/vcs-uri']);
-                //     if (path.isAbsolute(binaryUri.fsPath)) {
 
-                //     } else {
-
-                //     }
-                //     await Component.odo.execute(Command.createBinaryComponent(prjName, appName, componentJson.metadata.labels['app.kubernetes.io/name'], componentJson.metadata.labels['app.openshift.io/runtime-version'], compName, 'binary-location', workspaceFolder.fsPath));
                 if (componentType === ComponentType.GIT) {
                     const bcResult = await Component.odo.execute(`oc get bc/${componentJson.metadata.name} -o json`);
                     const bcJson = JSON.parse(bcResult.stdout);
@@ -648,9 +639,9 @@ export class Component extends OpenShiftItem {
                 } else {
                     workspace.updateWorkspaceFolders(workspace.workspaceFolders? workspace.workspaceFolders.length : 0 , null, { uri: workspaceFolder });
                 }
-                return `Component '${compName}' was sucessfully imported.`;
+                return `Component '${compName}' was successfully imported.`;
             } catch (errGetCompJson) {
-                return `Component import failed with error '${errGetCompJson.message}'.`;
+                throw new Error(`Component import failed with error '${errGetCompJson.message}'.`);
             }
         }); // create component with the same name
     }