Don't use conpty on Windows

datho7561 · datho7561 · commit 6c1ae69e993b · 2023-08-28T12:09:33.000-04:00
For whatever reason it doesn't work at all.

Signed-off-by: David Thompson &lt;davidethompson@me.com&gt;
diff --git a/src/webview/openshift-terminal/openShiftTerminal.ts b/src/webview/openshift-terminal/openShiftTerminal.ts
@@ -153,6 +153,7 @@ class OpenShiftTerminal {
             const escapedArgs = Array.isArray(this._args)
                 ? this._args.join(' ')
                 : this._args;
+            this._options.useConpty = false;
             this._pty = ptyInstance.spawn(
                 'C:\\WINDOWS\\system32\\cmd.EXE',
                 [

Original file line number	Diff line number	Diff line change
`@@ -153,6 +153,7 @@ class OpenShiftTerminal {`
`153`	`153`	`const escapedArgs = Array.isArray(this._args)`
`154`	`154`	`? this._args.join(' ')`
`155`	`155`	`: this._args;`
	`156`	`+ this._options.useConpty = false;`
`156`	`157`	`this._pty = ptyInstance.spawn(`
`157`	`158`	`'C:\\WINDOWS\\system32\\cmd.EXE',`
`158`	`159`	`[`