Skip to content

Commit 7374f72

Browse files
vrubezhnydatho7561
authored andcommitted
Remove the use of webview for describe and logs as replaced by OS Terminal
This commit completely removes the use of LazyLog-based webviews previously used to display the contents of component describe and show/follow log functionality. The "openshiftToolkit.useWebviewInsteadOfTerminalView" configuration preference is also removed as well as all its usages. Fixes: #1803 Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
1 parent 589a2cd commit 7374f72

19 files changed

+20
-947
lines changed

README.commands.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,9 @@ Commands available in context for the compenent
3939
* `Start Dev on Podman` - Run the above start dev workflow for applications deployed on Podman.
4040
* `Stop Dev` - Stop the dev command workflow and resources are cleaned, hence the application is not running on the cluster
4141
* `Show Dev Terminal` - Directly opens the VSCode terminal where the dev command is running.
42-
* `Describe` - Describe the given Component in terminal window or inside a webview editor.
43-
* `Show Log` - Retrieve the log for the given Component in the terminal or inside a webview editor (can be changed in VSCode Settings)
44-
* `Follow Log` - Follow logs for the given Component in the terminal or inside a webview editor (can be changed in VSCode Settings)
42+
* `Describe` - Describe the given Component in terminal window.
43+
* `Show Log` - Retrieve the log for the given Component in the terminal window.
44+
* `Follow Log` - Follow logs for the given Component in the terminal window.
4545
* `Open in Browser` - Open the exposed URL in default browser.
4646
* `Deploy` - Deploys a Component on the cluster by first building the images of the containers to deploy, then by deploying the Kubernetes resources necessary to deploy the components.
4747
* `Undeploy` - Undeploys a Component from the cluster. The component still resides in the local config.
@@ -56,7 +56,6 @@ future releases.
5656
* `OpenShift Toolkit: Show Channel On Output` - Show OpenShift Toolkit output channel when new text added to output stream
5757
* `OpenShift Toolkit: Output verbosity level` - Output verbosity level (value between 0 and 9) for OpenShift Create, Push and Watch commands in output channel and terminal view
5858
* `OpenShift Toolkit: Search CLI tools in PATH locations before using included binaries` - Force extension to search for `oc` and `odo` CLI tools in PATH locations before using bundled binaries
59-
* `OpenShift Toolkit: Use Webview based editors to show 'Show Log', 'Follow Log' and 'Describe' commands output` - Use Webview based editors instead of Terminal view to show or follow logs
6059
* `OpenShift Toolkit: CRC Executable Location` - Provide the path where OpenShift Local is installed.
6160
* `OpenShift Toolkit: CRC Pull Secret Path` - Provide the path where the pull secret file is present.
6261
* `OpenShift Toolkit: CRC Cpu Cores` - Number of CPU cores to allocate to the OpenShift cluster as selected during the first run.

build/esbuild.mjs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,8 @@ const webviews = [
1212
'cluster',
1313
'create-service',
1414
'create-component',
15-
'describe',
1615
'devfile-registry',
1716
'helm-chart',
18-
'log',
1917
'welcome',
2018
'feedback',
2119
'serverless-function',

0 commit comments

Comments
 (0)