Skip to content

Commit 8da7d46

Browse files
committed
Remove unsued methods from odo.ts
Signed-off-by: Denis Golovin dgolovin@redhat.com
1 parent b8d51be commit 8da7d46

File tree

1 file changed

+0
-31
lines changed

1 file changed

+0
-31
lines changed

src/odo.ts

Lines changed: 0 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -351,9 +351,7 @@ export interface Odo {
351351
deleteProject(project: OpenShiftObject): Promise<OpenShiftObject>;
352352
createApplication(application: OpenShiftObject): Promise<OpenShiftObject>;
353353
deleteApplication(application: OpenShiftObject): Promise<OpenShiftObject>;
354-
createComponentFromGit(application: OpenShiftObject, type: string, version: string, name: string, repoUri: string, context: Uri, ref: string): Promise<OpenShiftObject>;
355354
createComponentFromFolder(application: OpenShiftObject, type: string, version: string, registryName: string, name: string, path: Uri, starterName?: string, useExistingDevfile?: boolean, notification?: boolean): Promise<OpenShiftObject>;
356-
createComponentFromBinary(application: OpenShiftObject, type: string, version: string, name: string, path: Uri, context: Uri): Promise<OpenShiftObject>;
357355
deleteComponent(component: OpenShiftObject): Promise<OpenShiftObject>;
358356
undeployComponent(component: OpenShiftObject): Promise<OpenShiftObject>;
359357
deleteNotPushedComponent(component: OpenShiftObject): Promise<OpenShiftObject>;
@@ -913,35 +911,6 @@ export class OdoImpl implements Odo {
913911
return null;
914912
}
915913

916-
public async createComponentFromGit(application: OpenShiftObject, type: string, version: string, name: string, location: string, context: Uri, ref = 'master'): Promise<OpenShiftObject> {
917-
await this.execute(Command.createGitComponent(application.getParent().getName(), application.getName(), type, version, name, location, ref || 'master'), context.fsPath);
918-
// This check is here to skip any model updates when there are not workspace folders yet,
919-
// because when first folder added to workspace extesion is going to be reloaded anyway and
920-
// model loaded when extension is reactivated
921-
if (workspace.workspaceFolders) {
922-
const targetApplication = (await this.getApplications(application.getParent())).find((value) => value === application);
923-
if (!targetApplication) {
924-
await this.insertAndReveal(application);
925-
}
926-
await this.insertAndReveal(new OpenShiftComponent(application, name, ContextType.COMPONENT, context, odo.SourceType.GIT, version ? ComponentKind.S2I : ComponentKind.DEVFILE, version ? {name: type, tag: version} : undefined));
927-
}
928-
workspace.updateWorkspaceFolders(workspace.workspaceFolders? workspace.workspaceFolders.length : 0 , null, { uri: context });
929-
return null;
930-
}
931-
932-
public async createComponentFromBinary(application: OpenShiftObject, type: string, version: string, name: string, location: Uri, context: Uri): Promise<OpenShiftObject> {
933-
await this.execute(Command.createBinaryComponent(application.getParent().getName(), application.getName(), type, version, name, location.fsPath, context.fsPath));
934-
if (workspace.workspaceFolders) {
935-
const targetApplication = (await this.getApplications(application.getParent())).find((value) => value === application);
936-
if (!targetApplication) {
937-
await this.insertAndReveal(application);
938-
}
939-
this.insertAndReveal(new OpenShiftComponent(application, name, ContextType.COMPONENT, context, odo.SourceType.BINARY, version ? ComponentKind.S2I : ComponentKind.DEVFILE, {name: type, tag: version}));
940-
}
941-
workspace.updateWorkspaceFolders(workspace.workspaceFolders? workspace.workspaceFolders.length : 0 , null, { uri: context });
942-
return null;
943-
}
944-
945914
public async deleteComponent(component: OpenShiftObject): Promise<OpenShiftObject> {
946915
const app = component.getParent();
947916
await this.execute(

0 commit comments

Comments
 (0)