Skip to content

Commit 9b1cfda

Browse files
committed
[build] Use Node.js v20 engine as minimum version
The reasons: - The mainenance of Node.js v18 (LTS) ends 2025-04-30, so it's time to update the engine - A lot of used dependencies declare Node.js v20 as minimum version, it doesn't make sence to continue using v18 as minimum Node.js engine version, f.i.: ``` npm WARN EBADENGINE Unsupported engine { npm WARN EBADENGINE package: 'glob@11.0.1', npm WARN EBADENGINE required: { node: '20 || >=22' }, npm WARN EBADENGINE current: { node: 'v18.17.1', npm: '9.6.7' } npm WARN EBADENGINE } ... npm WARN EBADENGINE Unsupported engine { npm WARN EBADENGINE package: 'path-scurry@2.0.0', npm WARN EBADENGINE required: { node: '20 || >=22' }, npm WARN EBADENGINE current: { node: 'v18.17.1', npm: '9.6.7' } npm WARN EBADENGINE } ... npm WARN EBADENGINE Unsupported engine { npm WARN EBADENGINE package: 'lru-cache@11.0.0', npm WARN EBADENGINE required: { node: '20 || >=22' }, npm WARN EBADENGINE current: { node: 'v18.17.1', npm: '9.6.7' } npm WARN EBADENGINE } ``` Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
1 parent c816d07 commit 9b1cfda

File tree

3 files changed

+33
-15
lines changed

3 files changed

+33
-15
lines changed

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ There are only a few guidelines that we need contributors to follow.
88
## First Time Setup
99
1. Install prerequisites:
1010
* latest [Visual Studio Code](https://code.visualstudio.com/)
11-
* [Node.js](https://nodejs.org/) v18.17.0 or higher
11+
* [Node.js](https://nodejs.org/) v20 or higher
1212
* It is recommended to set up `nvm` to manage different versions of node, which can be installed by following the instructions [here](https://github.com/nvm-sh/nvm#installing-and-updating).
1313
* To use the current recommended version for this project (in`./nvmrc`), run `nvm use`.
1414
* [Red Hat Authentication](https://marketplace.visualstudio.com/items?itemName=redhat.vscode-redhat-account) VS Code plugin (VS Code will prompt to install this when you launch the extension if you don't have it)

package-lock.json

Lines changed: 29 additions & 11 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@
1414
"bugs": "https://github.com/redhat-developer/vscode-openshift-tools/issues",
1515
"engines": {
1616
"vscode": "^1.82.3",
17-
"npm": ">=8.6.0",
18-
"node": ">=18.0.0"
17+
"npm": ">=9.6.4",
18+
"node": ">=20.0.0"
1919
},
2020
"badges": [
2121
{
@@ -100,7 +100,7 @@
100100
"@types/git-url-parse": "^9.0.3",
101101
"@types/lodash": "^4.17.16",
102102
"@types/mocha": "^10.0.10",
103-
"@types/node": "^18.19.85",
103+
"@types/node": "^20.14.8",
104104
"@types/proxyquire": "^1.3.31",
105105
"@types/react": "^18.3.20",
106106
"@types/react-copy-to-clipboard": "^5.0.7",

0 commit comments

Comments
 (0)