Add 'OpenShift: Describe URL' command for URLs

Author: dgolovin

README.md

@@ -137,7 +137,6 @@ To debug a Java Component, Java Language Support and Java Debugger Extensions ar
 #### Actions available for a Storage in a Component
 
    * `Storage -> Delete` - Delete a Storage from a Component.
-   * `Storage -> Describe` - Describe the given Storage for the component in terminal window.
 
 
 #### Actions available for a Service in an Application

package.json

@@ -206,8 +206,6 @@
     "onCommand:openshift.component.debug",
     "onCommand:openshift.component.debug.palette",
     "onCommand:openshift.storage.create",
-    "onCommand:openshift.storage.describe",
-    "onCommand:openshift.storage.describe.palette",
     "onCommand:openshift.storage.delete",
     "onCommand:openshift.service.create",
     "onCommand:openshift.service.delete",
@@ -565,16 +563,6 @@
         "title": "Delete",
         "category": "OpenShift"
       },
-      {
-        "command": "openshift.storage.describe",
-        "title": "Describe",
-        "category": "OpenShift"
-      },
-      {
-        "command": "openshift.storage.describe.palette",
-        "title": "Describe Storage",
-        "category": "OpenShift"
-      },
       {
         "command": "openshift.service.create",
         "title": "New Service",
@@ -811,10 +799,6 @@
           "command": "openshift.component.push",
           "when": "view == openshiftProjectExplorer"
         },
-        {
-          "command": "openshift.storage.describe",
-          "when": "view == openshiftProjectExplorer"
-        },
         {
           "command": "openshift.storage.delete",
           "when": "view == openshiftProjectExplorer"
@@ -1117,11 +1101,6 @@
           "when": "view == openshiftProjectExplorer && viewItem == service",
           "group": "s2"
         },
-        {
-          "command": "openshift.storage.describe",
-          "when": "view == openshiftProjectExplorer && viewItem == storage",
-          "group": "s3"
-        },
         {
           "command": "openshift.storage.delete",
           "when": "view == openshiftProjectExplorer && viewItem == storage",

src/openshift/storage.ts

@@ -6,7 +6,7 @@
 import { window } from 'vscode';
 import { isEmpty } from "validator";
 import OpenShiftItem from "./openshiftItem";
-import { OpenShiftObject, ContextType, Command } from "../odo";
+import { OpenShiftObject, ContextType } from "../odo";
 import { Progress } from "../util/progress";
 import { vsCommand, VsCommandError } from '../vscommand';
 
@@ -60,15 +60,4 @@ export class Storage extends OpenShiftItem {
         }
         return null;
     }
-
-    @vsCommand('openshift.storage.describe', true)
-    static async describe(treeItem: OpenShiftObject): Promise<void> {
-        let storage = treeItem;
-        const component = await Storage.getOpenShiftCmdData(storage,
-            "From which Project you want to describe Storage",
-            "From which Application you want to describe Storage",
-            "From which Component you want to describe Storage");
-        if (!storage && component) storage = await window.showQuickPick(Storage.getStorageNames(component), {placeHolder: "Select Storage to describe", ignoreFocusOut: true});
-        if (storage) Storage.odo.executeInTerminal(Command.describeStorage(storage.getName()));
-    }
 }

test/unit/openshift/storage.test.ts

@@ -20,7 +20,6 @@ suite('OpenShift/Storage', () => {
     let execStub: sinon.SinonStub;
     let quickPickStub: sinon.SinonStub;
     let inputStub: sinon.SinonStub;
-    let termStub: sinon.SinonStub;
     let getProjectNamesStub: sinon.SinonStub;
     let getStorageNamesStub: sinon.SinonStub;
     const projectItem = new TestItem(null, 'project', ContextType.PROJECT);
@@ -34,7 +33,6 @@ suite('OpenShift/Storage', () => {
     setup(() => {
         sandbox = sinon.createSandbox();
         getStorageNamesStub = sandbox.stub(OdoImpl.prototype, 'getStorageNames').resolves([storageItem]);
-        termStub = sandbox.stub(OdoImpl.prototype, 'executeInTerminal');
         execStub = sandbox.stub(OdoImpl.prototype, 'execute').resolves({error: '', stdout: '', stderr: ''});
         quickPickStub = sandbox.stub(vscode.window, 'showQuickPick');
     });
@@ -342,36 +340,4 @@ suite('OpenShift/Storage', () => {
             }
         });
     });
-
-    suite('describe', () => {
-
-        setup(() => {
-            sandbox.stub(OdoImpl.prototype, 'getProjects').resolves([]);
-            sandbox.stub(OdoImpl.prototype, 'getApplications').resolves([]);
-            sandbox.stub(OdoImpl.prototype, 'getComponents').resolves([]);
-            getStorageNamesStub.resolves([]);
-            quickPickStub.onFirstCall().resolves(projectItem);
-            quickPickStub.onSecondCall().resolves(appItem);
-            quickPickStub.onThirdCall().resolves(componentItem);
-            quickPickStub.onCall(3).resolves(storageItem);
-        });
-
-        test('calls the correct odo command w/ context', async () => {
-            await Storage.describe(storageItem);
-
-            expect(termStub).calledOnceWith(Command.describeUrl(storageItem.getName()));
-        });
-
-        test('calls the correct odo command w/o context', async () => {
-            await Storage.describe(null);
-
-            expect(termStub).calledOnceWith(Command.describeUrl(storageItem.getName()));
-        });
-
-        test('does not call the odo command if canceled', async () => {
-            sandbox.stub(Storage, 'getOpenShiftCmdData').resolves(null);
-            await Storage.describe(null);
-            expect(termStub).not.called;
-        });
-    });
 });