Add UI to create service binding

Right click on a component in the components view and select "Bind
Service" in order to bind the component to an Operator-backed service.

In order for this to work:
- the service binding operator must be installed on the cluster
- an operator that manages instances of services must be installed
  (I tested with the RHOAS operator)
- there must be an instance of the service that is managed by the operator in the current project

Other things in this PR:
- Add a walkthrough GIF of using the UI
- Add a smoke test to check that the "Bind Service" context menu item
  exists
- Fix the smoke tests.
  This includes fixing the existing test case for #2780,
  even though we are going to rewrite that as a WebView UI soon.
  I did this, since for the "Bind Service" smoke test,
  we need a component present in the components view.

Signed-off-by: David Thompson <davthomp@redhat.com>

Author: datho7561

.eslintignore

@@ -9,7 +9,6 @@ test-resources
 src/webview/log
 src/webview/describe
 src/webview/cluster
-src/webview/webpack.config.js
 out
 src/webview/common
 src/webview/create-service

build/esbuild.mjs

@@ -16,7 +16,8 @@ const webviews = [
     'helm-chart',
     'log',
     'welcome',
-    'feedback'
+    'feedback',
+    'add-service-binding',
 ];
 
 function kebabToCamel(text) {

images/walkthrough/addServiceBinding.gif

@@ -440,6 +440,11 @@
 				"title": "Start Dev",
 				"category": "OpenShift"
 			},
+			{
+				"command": "openshift.component.binding.add",
+				"title": "Bind Service",
+				"category": "OpenShift"
+			},
 			{
 				"command": "openshift.component.exitDevMode",
 				"title": "Stop Dev",
@@ -510,6 +515,10 @@
 				"title": "Open Console Dashboard for Current Cluster",
 				"category": "OpenShift"
 			},
+			{
+				"command": "openshift.open.operatorBackedServiceCatalog",
+				"title": "Open Operator Backed Service Catalog"
+			},
 			{
 				"command": "openshift.component.debug",
 				"title": "Debug",
@@ -910,6 +919,10 @@
 					"command": "openshift.open.developerConsole",
 					"when": "view == openshiftProjectExplorer"
 				},
+				{
+					"command": "openshift.open.operatorBackedServiceCatalog",
+					"when": "false"
+				},
 				{
 					"command": "openshift.component.debug",
 					"when": "view == openshiftProjectExplorer"
@@ -1069,6 +1082,10 @@
 				{
 					"command": "openshift.component.openInBrowser",
 					"when": "false"
+				},
+				{
+					"command": "openshift.component.binding.add",
+					"when": "false"
 				}
 			],
 			"view/title": [
@@ -1309,6 +1326,11 @@
 					"when": "view == openshiftComponentsView && viewItem =~ /openshift\\.component.*\\.dep-nrn.*/ || viewItem =~ /openshift\\.component.*\\.dep-run.*/",
 					"group": "c2@1"
 				},
+				{
+					"command": "openshift.component.binding.add",
+					"when": "view == openshiftComponentsView && viewItem =~ /openshift\\.component.*\\.dev-nrn.*/",
+					"group": "c2@2"
+				},
 				{
 					"command": "openshift.component.showDevTerminal",
 					"when": "view == openshiftComponentsView && viewItem =~ /openshift\\.component.*\\.dev-run.*/",

package.json

@@ -89,7 +89,7 @@ export interface Odo {
      */
     getActiveProject(): Promise<string>;
 
-    /*
+    /**
      * Deletes all the odo configuration files associated with the component (`.odo`, `devfile.yaml`) located at the given path.
      *
      * @param componentPath the path to the component

src/odo.ts

@@ -320,4 +320,20 @@ export class Command {
         return new CommandText('oc api-resources | grep openshift');
     }
 
+    static addBinding(serviceNamespace: string, serviceName: string, bindingName: string): CommandText {
+        return new CommandText('odo add binding',
+            undefined,
+            [
+                new CommandOption('--service-namespace', serviceNamespace, false),
+                new CommandOption('--service', serviceName, false),
+                new CommandOption('--name', bindingName, false),
+            ]
+        )
+    }
+
+    static getBindableServices(): CommandText {
+        return new CommandText('odo list service',
+            undefined,
+            [new CommandOption('-o json')]);
+    }
 }

src/odo/command.ts

@@ -5,7 +5,7 @@
 
 import { KubernetesObject } from '@kubernetes/client-node';
 import { CommandText } from './base/command';
-import { CliChannel } from './cli';
+import { CliChannel, CliExitData } from './cli';
 import { Command as CommonCommand, loadItems } from './k8s/common';
 import { Command as DeploymentCommand } from './k8s/deployment';
 import { DeploymentConfig } from './k8s/deploymentConfig';
@@ -20,6 +20,30 @@ export interface Odo3 {
     setNamespace(newNamespace: string): Promise<void>;
 
     describeComponent(contextPath: string): Promise<ComponentDescription | undefined>;
+
+    /**
+     * Bind a component to a bindable service by modifying the devfile
+     *
+     * Resolves when the binding it created.
+     *
+     * @param contextPath the path to the component
+     * @param serviceName the name of the service to bind to
+     * @param serviceNamespace the namespace the the service is in
+     * @param bindingName the name of the service binding
+     */
+    addBinding(
+        contextPath: string,
+        serviceName: string,
+        serviceNamespace: string,
+        bindingName: string,
+    ): Promise<void>;
+
+    /**
+     * Returns a list of all the bindable services on the cluster.
+     *
+     * @returns a list of all the bindable services on the cluster
+     */
+    getBindableServices(): Promise<KubernetesObject[]>;
 }
 
 export class Odo3Impl implements Odo3 {
@@ -69,6 +93,49 @@ export class Odo3Impl implements Odo3 {
             // ignore and return undefined
         }
     }
+
+    async addBinding(contextPath: string, serviceNamespace: string, serviceName: string, bindingName: string) {
+        const myCommand = Command.addBinding(serviceNamespace, serviceName, bindingName);
+        await CliChannel.getInstance().executeTool(
+            myCommand,
+            {cwd: contextPath},
+            true
+        );
+    }
+
+    async getBindableServices(): Promise<KubernetesObject[]> {
+        const data: CliExitData = await CliChannel.getInstance().executeTool(
+            Command.getBindableServices()
+        );
+        let responseObj;
+        try {
+            responseObj = JSON.parse(data.stdout);
+        } catch {
+            throw new Error(JSON.parse(data.stderr).message);
+        }
+        if (!responseObj.bindableServices) {
+            return [];
+        }
+        return (responseObj.bindableServices as BindableService[]) //
+            .map(obj => {
+                return {
+                    kind: obj.kind,
+                    apiVersion: obj.apiVersion,
+                    metadata: {
+                        namespace: obj.namespace,
+                        name: obj.name,
+                    }
+                } as KubernetesObject;
+            });
+    }
+}
+
+interface BindableService {
+    name: string;
+    namespace: string;
+    kind: string;
+    apiVersion: string;
+    service: string;
 }
 
 export function newInstance(): Odo3 {

src/odo3.ts

@@ -6,6 +6,7 @@
 import { KubernetesObject } from '@kubernetes/client-node';
 import { ExtensionContext, QuickInputButton, QuickPickItem, QuickPickItemButtonEvent, Terminal, ThemeIcon, Uri, Progress as VProgress, WebviewPanel, commands, env, window, workspace } from 'vscode';
 import { CliChannel, CliExitData } from '../cli';
+import { getInstance } from '../odo';
 import { Command } from '../odo/command';
 import { TokenStore } from '../util/credentialManager';
 import { Filters } from '../util/filters';
@@ -96,6 +97,20 @@ export class Cluster extends OpenShiftItem {
         });
     }
 
+    @vsCommand('openshift.open.operatorBackedServiceCatalog')
+    @clusterRequired()
+    static async openOpenshiftConsoleTopography(): Promise<void> {
+        return Progress.execFunctionWithProgress('Opening Operator Backed Service Catalog', async (progress) => {
+            const [consoleUrl, namespace] = await Promise.all([
+                Cluster.getConsoleUrl(progress),
+                getInstance().getActiveProject()
+            ]);
+            progress.report({increment: 100, message: 'Starting default browser'});
+            // eg. https://console-openshift-console.apps-crc.testing/catalog/ns/default?catalogType=OperatorBackedService
+            return commands.executeCommand('vscode.open', Uri.parse(`${consoleUrl}/catalog/ns/${namespace}?catalogType=OperatorBackedService`));
+        });
+    }
+
     @vsCommand('openshift.resource.openInDeveloperConsole')
     @clusterRequired()
     static async openInDeveloperConsole(resource: KubernetesObject): Promise<void> {

src/openshift/cluster.ts

@@ -15,14 +15,16 @@ import { Command } from '../odo/command';
 import { ComponentTypeAdapter, ComponentTypeDescription, DevfileComponentType, ascDevfileFirst, isDevfileComponent } from '../odo/componentType';
 import { StarterProject, isStarterProject } from '../odo/componentTypeDescription';
 import { ComponentWorkspaceFolder } from '../odo/workspace';
+import * as odo3 from '../odo3';
 import { NewComponentCommandProps } from '../telemetry';
 import { Progress } from '../util/progress';
 import { selectWorkspaceFolder } from '../util/workspace';
 import { VsCommandError, vsCommand } from '../vscommand';
+import AddServiceBindingViewLoader, { ServiceBindingFormResponse } from '../webview/add-service-binding/addServiceBindingViewLoader';
+import DescribeViewLoader from '../webview/describe/describeViewLoader';
 import GitImportLoader from '../webview/git-import/gitImportLoader';
 import LogViewLoader from '../webview/log/LogViewLoader';
 import OpenShiftItem, { clusterRequired } from './openshiftItem';
-import DescribeViewLoader from '../webview/describe/describeViewLoader';
 
 function createCancelledResult(stepName: string): any {
     const cancelledResult: any = new String('');
@@ -203,6 +205,72 @@ export class Component extends OpenShiftItem {
         return Component.dev(component, 'podman');
     }
 
+    @vsCommand('openshift.component.binding.add')
+    static async addBinding(component: ComponentWorkspaceFolder) {
+        const odo: odo3.Odo3 = odo3.newInstance();
+
+        const services = await Progress.execFunctionWithProgress('Looking for bindable services', (progress) => {
+            return odo.getBindableServices();
+        });
+
+        if (!services || services.length === 0) {
+            void window.showErrorMessage('No bindable services are available', 'Open Service Catalog in OpenShift Console')
+                .then((result) => {
+                    if (result === 'Open Service Catalog in OpenShift Console') {
+                        void commands.executeCommand('openshift.open.operatorBackedServiceCatalog')
+                    }
+                });
+            return;
+        }
+
+        let formResponse: ServiceBindingFormResponse = undefined;
+        try {
+            formResponse = await new Promise<ServiceBindingFormResponse>(
+                (resolve, reject) => {
+                    void AddServiceBindingViewLoader.loadView(
+                        component.contextPath,
+                        services.map(
+                            (service) => `${service.metadata.namespace}/${service.metadata.name}`,
+                        ),
+                        (panel) => {
+                            panel.onDidDispose((_e) => {
+                                reject(new Error('The \'Add Service Binding\' wizard was closed'));
+                            });
+                            return async (eventData) => {
+                                if (eventData.action === 'addServiceBinding') {
+                                    resolve(eventData.params);
+                                    await panel.dispose();
+                                }
+                            };
+                        },
+                    ).then(view => {
+                        if (!view) {
+                            // the view was already created
+                            reject();
+                        }
+                    });
+                },
+            );
+        } catch (e) {
+            // The form was closed without submitting,
+            // or the form already exists for this component.
+            // stop the command.
+            return;
+        }
+
+        const selectedServiceObject = services.filter(
+            (service) =>
+                `${service.metadata.namespace}/${service.metadata.name}` === formResponse.selectedService,
+        )[0];
+
+        await odo.addBinding(
+            component.contextPath,
+            selectedServiceObject.metadata.namespace,
+            selectedServiceObject.metadata.name,
+            formResponse.bindingName,
+        );
+    }
+
     @vsCommand('openshift.component.dev')
     @clusterRequired()
     static async dev(component: ComponentWorkspaceFolder, runOn?: undefined | 'podman') {