Fix hidden unit test errors

Author: dgolovin

package.json

@@ -61,7 +61,8 @@
     "onCommand:openshift.component.log",
     "onCommand:openshift.component.unlink",
     "onCommand:openshift.component.unlink.palette",
-    "onCommand:openshift.component.unlink.service.palette",
+    "onCommand:openshift.component.unlinkComponent.palette",
+    "onCommand:openshift.component.unlinkService.palette",
     "onCommand:openshift.component.log.palette",
     "onCommand:openshift.component.followLog",
     "onCommand:openshift.component.followLog.palette",
@@ -277,12 +278,12 @@
         "category": "OpenShift"
       },
       {
-        "command": "openshift.component.unlink.component.palette",
+        "command": "openshift.component.unlinkComponent.palette",
         "title": "Unlink Component",
         "category": "OpenShift"
       },
       {
-        "command": "openshift.component.unlink.service.palette",
+        "command": "openshift.component.unlinkService.palette",
         "title": "Unlink Service",
         "category": "OpenShift"
       },

src/extension.ts

@@ -101,8 +101,8 @@ export async function activate(context: vscode.ExtensionContext) {
         vscode.commands.registerCommand('openshift.service.describe.palette', (context) => execute(Service.describe, context)),
         vscode.commands.registerCommand('openshift.component.linkComponent', (context) => execute(Component.linkComponent, context)),
         vscode.commands.registerCommand('openshift.component.unlink', (context) => execute(Component.unlink, context)),
-        vscode.commands.registerCommand('openshift.component.unlink.component.palette', (context) => execute(Component.unlinkComponent, context)),
-        vscode.commands.registerCommand('openshift.component.unlink.service.palette', (context) => execute(Component.unlinkService, context)),
+        vscode.commands.registerCommand('openshift.component.unlinkComponent.palette', (context) => execute(Component.unlinkComponent, context)),
+        vscode.commands.registerCommand('openshift.component.unlinkService.palette', (context) => execute(Component.unlinkService, context)),
         vscode.commands.registerCommand('openshift.component.linkService', (context) => execute(Component.linkService, context)),
         vscode.commands.registerCommand('openshift.explorer.reportIssue', () => OpenShiftExplorer.reportIssue()),
         vscode.commands.registerCommand('clusters.openshift.useProject', (context) => vscode.commands.executeCommand('extension.vsKubernetesUseNamespace', context)),

test/unit/extension.test.ts

@@ -67,15 +67,14 @@ suite('openshift connector Extension', async () => {
 		assert.ok(vscode.extensions.getExtension('redhat.vscode-openshift-connector'));
 	});
 
-    async function getStaticMethodsToStub(osc: string[]): Promise<string[]> {
+    function getStaticMethodsToStub(osc: string[]): string[] {
         const mths: Set<string> = new Set();
         osc.forEach((name) => {
             name = name.replace('.palette', '');
             const segs: string[] = name.split('.');
             let methName: string = segs[segs.length-1];
             methName = methName === 'delete'? 'del' : methName;
             !mths.has(methName) && mths.add(methName);
-
         });
         return [...mths];
     }
@@ -84,15 +83,17 @@ suite('openshift connector Extension', async () => {
         sandbox.stub(vscode.window, 'showErrorMessage');
         const cmds: string[] = await vscode.commands.getCommands();
         const osc: string[] = cmds.filter((item) => item.startsWith('openshift.'));
-        const mths: string[] = await getStaticMethodsToStub(osc);
+        const mths: string[] = getStaticMethodsToStub(osc);
         [Application, Catalog, Cluster, Component, Project, Service, Storage, Url, OpenShiftExplorer].forEach((item: { [x: string]: any; }) => {
             mths.forEach((name) => {
                 if (item[name]) {
                     sandbox.stub(item, name).resolves();
                 }
             });
         });
-        osc.forEach((item) => vscode.commands.executeCommand(item));
+        for (const command of osc) {
+            await vscode.commands.executeCommand(command);
+        }
         expect(vscode.window.showErrorMessage).has.not.been.called;
     });