Skip to content

Commit e1be296

Browse files
Merge branch 'main' into 3911-workflow-for-entering-a-bad-container-image-url-isnt-good
2 parents 532b069 + 640cd35 commit e1be296

File tree

3 files changed

+22
-9
lines changed

3 files changed

+22
-9
lines changed

package-lock.json

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@
159159
"mocha": "^10.6.0",
160160
"mocha-jenkins-reporter": "^0.4.7",
161161
"npm-run-all": "^4.1.5",
162-
"prettier": "^3.3.2",
162+
"prettier": "^3.3.3",
163163
"pretty-bytes": "^6.1.1",
164164
"proxyquire": "^2.1.3",
165165
"react": "^17.0.2",

test/ui/common/ui/webview/newComponentWebViewEditor.ts

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,7 @@ export class LocalCodeBasePage extends Page {
208208

209209
public async clickCreateComponent(): Promise<void> {
210210
await this.enterWebView(async (webView) => {
211-
const button = await this.getCreateComponentButton(webView);
211+
const button = await this.createButtonExists(webView);
212212
await button.click();
213213
});
214214
}
@@ -221,6 +221,19 @@ export class LocalCodeBasePage extends Page {
221221
return await webView.findWebElement(By.xpath('//button[contains(text(), "Select Folder")]'));
222222
}
223223

224+
private async createButtonExists(webView: WebView, timeout = 60_000): Promise<WebElement> {
225+
return webView.getDriver().wait(async () => {
226+
try {
227+
const button = await this.getCreateComponentButton(webView);
228+
if (button) {
229+
return button;
230+
}
231+
} catch (err) {
232+
return null;
233+
}
234+
}, timeout);
235+
}
236+
224237
private async getCreateComponentButton(webView: WebView): Promise<WebElement> {
225238
return await webView.findWebElement(By.xpath('//span[contains(text(), "Create Component")]'));
226239
}

0 commit comments

Comments
 (0)