Skip to content

Commit b4bf87b

Browse files
dkwon17fbricon
authored andcommitted
Add disposables to context.subscriptions
Signed-off-by: David Kwon <dakwon@redhat.com>
1 parent 1de1af8 commit b4bf87b

File tree

2 files changed

+7
-11
lines changed

2 files changed

+7
-11
lines changed

src/debugging/terminateProcess.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ import { getRunningQuarkusDevTasks } from '../utils/tasksUtils';
2020
import { BuildSupport } from '../buildSupport/BuildSupport';
2121
import { getBuildSupport } from '../buildSupport/BuildSupportUtils';
2222

23-
export function createTerminateDebugListener(disposables: Disposable[]): Disposable {
23+
export function createTerminateDebugListener(): Disposable {
2424

2525
return debug.onDidTerminateDebugSession(async (debugSession: DebugSession) => {
2626

@@ -41,7 +41,7 @@ export function createTerminateDebugListener(disposables: Disposable[]): Disposa
4141
quarkusDevTaskExe.terminate();
4242
}
4343

44-
}, null, disposables);
44+
});
4545
}
4646

4747
function checkHasPreLaunchTask(debugSession: DebugSession): void {

src/extension.ts

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,6 @@ import { tryStartDebugging } from './debugging/startDebugging';
2828
import { WelcomeWebview } from './webviews/WelcomeWebview';
2929
import { QuarkusConfig } from './QuarkusConfig';
3030

31-
const disposables = [];
32-
let terminateDebugListener: Disposable;
3331
let languageClient: LanguageClient;
3432

3533
interface QuarkusProjectInfoParams {
@@ -52,15 +50,15 @@ export function activate(context: ExtensionContext) {
5250
QuarkusContext.setContext(context);
5351
displayWelcomePageIfNeeded(context);
5452

55-
terminateDebugListener = createTerminateDebugListener(disposables);
53+
context.subscriptions.push(createTerminateDebugListener());
5654

57-
connectToLS().then(() => {
55+
connectToLS(context).then(() => {
5856
const quarkusPojectInfoRequest = new RequestType<QuarkusProjectInfoParams, any, void, void>(QuarkusLS.PROJECT_REQUEST);
5957
languageClient.onRequest(quarkusPojectInfoRequest, async (params: QuarkusProjectInfoParams) =>
6058
<any> await commands.executeCommand("java.execute.workspaceCommand", JdtLSCommands.PROJECT_INFO_COMMAND, params)
6159
);
6260

63-
const quarkusPropertyDefinitionRequest = new RequestType<QuarkusPropertyDefinitionParams, any, void, void>(QuarkusLS.PROPERTY_DEFINITION_REQUEST);
61+
const quarkusPropertyDefinitionRequest = new RequestType<QuarkusPropertyDefinitionParams, any, void, void>(QuarkusLS.PROPERTY_DEFINITION_REQUEST);
6462
languageClient.onRequest(quarkusPropertyDefinitionRequest, async (params: QuarkusPropertyDefinitionParams) =>
6563
<any> await commands.executeCommand("java.execute.workspaceCommand", JdtLSCommands.PROPERTY_DEFINITION_COMMAND, params)
6664
);
@@ -84,8 +82,6 @@ export function activate(context: ExtensionContext) {
8482
}
8583

8684
export function deactivate() {
87-
terminateDebugListener.dispose();
88-
disposables.forEach(disposable => disposable.dispose());
8985
}
9086

9187
function displayWelcomePageIfNeeded(context: ExtensionContext): void {
@@ -125,7 +121,7 @@ function registerVSCodeCommands(context: ExtensionContext) {
125121
}));
126122
}
127123

128-
function connectToLS() {
124+
function connectToLS(context: ExtensionContext) {
129125
return requirements.resolveRequirements().then(requirements => {
130126
const clientOptions: LanguageClientOptions = {
131127
documentSelector: [
@@ -150,7 +146,7 @@ function connectToLS() {
150146

151147
const serverOptions = prepareExecutable(requirements);
152148
languageClient = new LanguageClient('quarkus.tools', 'Quarkus Tools', serverOptions, clientOptions);
153-
disposables.push(languageClient.start());
149+
context.subscriptions.push(languageClient.start());
154150
return languageClient.onReady();
155151
});
156152

0 commit comments

Comments
 (0)