autoClosingBrackets are forced off if autoCloseTags is enabled

Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>

Author: NikolasKomonen

package.json

@@ -148,8 +148,19 @@
           "default": true,
           "description": "Enable/disable ability to autoclose tags. \n\n**IMPORTANT: Turn off editor.autoClosingTags for this to work\n**",
           "scope": "window"
+        },
+        "xml.completion.testSetting": {
+          "type": "boolean",
+          "default": true,
+          "description": "Enable/disable ability to autoclose tags. \n\n**IMPORTANT: Turn off editor.autoClosingTags for this to work\n**",
+          "scope": "window"
         }
       }
+    },
+    "configurationDefaults": {
+        "[xml]": {
+          "editor.autoClosingBrackets": "never"
+        }
     }
   }
 }

src/extension.ts

@@ -17,7 +17,7 @@ import { languages, IndentAction, workspace, window, commands, ExtensionContext,
 import * as path from 'path';
 import * as os from 'os';
 import { activateTagClosing } from './tagClosing';
-
+var oldSettings = {};
 namespace TagCloseRequest {
   export const type: RequestType<TextDocumentPositionParams, string, any, any> = new RequestType('xml/closeTag');
 }
@@ -45,15 +45,16 @@ export function activate(context: ExtensionContext) {
       revealOutputChannelOn: RevealOutputChannelOn.Never,
       initializationOptions: { settings: getSettings() },
       synchronize: {
-        configurationSection: ['xml']
+        configurationSection: ['xml', '[xml]']
       },
       middleware: {
         workspace: {
           didChangeConfiguration: () => languageClient.sendNotification(DidChangeConfigurationNotification.type, { settings: getSettings() })
+          
         }
       }
     }
-
+    
     let serverOptions = prepareExecutable(requirements);
     let languageClient = new LanguageClient('xml', 'XML Support', serverOptions, clientOptions);
     let toDispose = context.subscriptions;
@@ -75,6 +76,17 @@ export function activate(context: ExtensionContext) {
 
   function getSettings(): JSON {
     let configXML = workspace.getConfiguration();
+    
+    let autoCloseTags = configXML.get("xml.completion.autoCloseTags");
+    let autoClosingBrackets = configXML.get("[xml]")["editor.autoClosingBrackets"];
+    if(autoCloseTags && autoClosingBrackets != "never") {
+      window.showInformationMessage("Since xml.completion.autoCloseTags is enabled, [xml].editor.autoClosingBrackets was set to 'never'.");
+      workspace.getConfiguration().update("[xml]", {"editor.autoClosingBrackets": "never"}, true).then(
+        () => console.log("testSetting" + ' globally set to ' + "false"),
+        (error) => console.log(error)
+      );
+    }
+    
     configXML = configXML.get('xml');
     let settings: JSON;
     if (!configXML) {
@@ -102,10 +114,6 @@ export function activate(context: ExtensionContext) {
     settings['logs']['file'] = logfile;
     return settings;
   }
-
-
-
-
 }
 function getIndentationRules(): LanguageConfiguration {
   return {